fix: strict zip of items that fail on __eq__

aiostream/stream/combine.py

@@ -91,9 +91,9 @@ async def zip(
             if strict:
                 coros = (anext(streamer, STOP_SENTINEL) for streamer in streamers)
                 _items = await asyncio.gather(*coros)
-                if all(item == STOP_SENTINEL for item in _items):
+                if all(isinstance(item, _StopSentinelType) for item in _items):
                     break
-                elif any(item == STOP_SENTINEL for item in _items):
+                elif any(isinstance(item, _StopSentinelType) for item in _items):
                     raise ValueError("The provided sources have different lengths")
                 # This holds because we've ruled out STOP_SENTINEL above:
                 items = cast("list[T]", _items)

tests/test_combine.py

@@ -1,3 +1,4 @@
+from functools import partial
 from typing import Awaitable
 import pytest
 import asyncio
@@ -22,6 +23,29 @@ async def test_chain(assert_run, assert_cleanup):
     await assert_run(xs, [])
 
 
+class ThrowsInEquality:
+
+    def __eq__(self, other):
+        raise Exception("We should not reach this!")
+
+
+@pytest.fixture(
+    params=[stream.range, partial(stream.repeat, ThrowsInEquality())],
+    ids=["range", "iterator_of_items_that_throw"],
+)
+def make_range(request):
+    return request.param
+
+
+@pytest.mark.asyncio
+async def test_zip_strict(make_range):
+    xs = make_range(3)
+    ys = make_range(2)
+    zs = stream.zip(xs, ys, strict=True)
+    with pytest.raises(ValueError, match="The provided sources have different lengths"):
+        await zs
+
+
 @pytest.mark.asyncio
 async def test_zip(assert_run):
     xs = stream.range(5) | add_resource.pipe(1.0)