Skip to content

[WFCORE-7678] Add --add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED to the default modular JVM options - #6893

Open
rhusar wants to merge 1 commit into
wildfly:mainfrom
rhusar:WFCORE-7678
Open

[WFCORE-7678] Add --add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED to the default modular JVM options#6893
rhusar wants to merge 1 commit into
wildfly:mainfrom
rhusar:WFCORE-7678

Conversation

@rhusar

@rhusar rhusar commented Aug 14, 2026

Copy link
Copy Markdown
Member

Required by the ProtoStream annotation marshaller introduced in wildfly-clustering 12, which uses MethodHandles.privateLookupIn(...) on sun.reflect.annotation.AnnotationInvocationHandler. Without this option, marshalling of annotations is disabled.

https://redhat.atlassian.net/browse/WFCORE-7678

Launcher PR: wildfly/wildfly-launcher#91

@rhusar

rhusar commented Aug 14, 2026

Copy link
Copy Markdown
Member Author

@pferraro for review

…NAMED to the default modular JVM options

Required by the ProtoStream annotation marshaller introduced in wildfly-clustering 12, which uses MethodHandles.privateLookupIn(...) on sun.reflect.annotation.AnnotationInvocationHandler.
Without this option, marshalling of annotations is disabled.

Signed-off-by: Radoslav Husar <rhusar@ibm.com>
@wildfly-ci

Copy link
Copy Markdown

Core -> Full Integration (with SecurityManager) Build 308 outcome was UNKNOWN using a merge of 8456594
Summary: Canceled (Error while applying patch; cannot find commit dff77e1 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6893/merge branch was updated and the commit selected for the ... Build time: 00:00:30

@wildfly-ci

Copy link
Copy Markdown

Core -> WildFly Preview Integration Build 316 outcome was UNKNOWN using a merge of 8456594
Summary: Canceled (Error while applying patch; cannot find commit dff77e1 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6893/merge branch was updated and the commit selected for the ... Build time: 00:00:22

@wildfly-ci

Copy link
Copy Markdown

Core -> Full Integration (with SecurityManager) Build 15636 outcome was UNKNOWN using a merge of 8456594
Summary: Canceled (Error while applying patch; cannot find commit dff77e1 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6893/merge branch was updated and the commit selected for the ... Build time: 00:00:22

@wildfly-ci

Copy link
Copy Markdown

Core -> Full Integration Build 15311 outcome was UNKNOWN using a merge of 8456594
Summary: Canceled (Error while applying patch; cannot find commit dff77e1 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6893/merge branch was updated and the commit selected for the ... Build time: 00:00:22

@rhusar

rhusar commented Aug 14, 2026

Copy link
Copy Markdown
Member Author

/retest

cannot find commit..

@rhusar

rhusar commented Aug 14, 2026

Copy link
Copy Markdown
Member Author

Oh, and before someone asks about what happens when running on a JDK that does not have this sun.* package:

"If a specified module was not resolved, or if a specified package does not exist, then the corresponding pair is ignored."

As defined in the JEP 261: Module System – https://openjdk.org/jeps/261#:~:text=pair%20is%20ignored.

@rhusar
rhusar requested a review from pferraro August 14, 2026 17:41
@yersan

yersan commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@rhusar This conflicted with a recent change removing the optional settings for jdks below 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants