Skip to content

[WFCORE-7678] Add --add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED to the default modular JVM options #6893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rhusar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WFCORE-7678] Add --add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED to the default modular JVM options #6893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core-feature-pack/common/src/main/resources/content/bin/common.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ goto :eof
set "DEFAULT_MODULAR_JVM_OPTIONS=!DEFAULT_MODULAR_JVM_OPTIONS! --add-opens=java.base/java.util=ALL-UNNAMED"
rem Needed for marshalling of concurrent collections
set "DEFAULT_MODULAR_JVM_OPTIONS=!DEFAULT_MODULAR_JVM_OPTIONS! --add-opens=java.base/java.util.concurrent=ALL-UNNAMED"
rem Needed for marshalling of annotations
set "DEFAULT_MODULAR_JVM_OPTIONS=!DEFAULT_MODULAR_JVM_OPTIONS! --add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED"
rem EE integration with sar mbeans requires deep reflection in javax.management
set "DEFAULT_MODULAR_JVM_OPTIONS=!DEFAULT_MODULAR_JVM_OPTIONS! --add-opens=java.management/javax.management=ALL-UNNAMED"
rem InitialContext proxy generation requires deep reflection in javax.naming
Expand Down
2 changes: 2 additions & 0 deletions core-feature-pack/common/src/main/resources/content/bin/common.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,8 @@ Param(
$DEFAULT_MODULAR_JVM_OPTIONS += "--add-opens=java.base/java.util=ALL-UNNAMED"
# Needed for marshalling of concurrent collections
$DEFAULT_MODULAR_JVM_OPTIONS += "--add-opens=java.base/java.util.concurrent=ALL-UNNAMED"
# Needed for marshalling of annotations
$DEFAULT_MODULAR_JVM_OPTIONS += "--add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED"
# EE integration with sar mbeans requires deep reflection in javax.management
$DEFAULT_MODULAR_JVM_OPTIONS += "--add-opens=java.management/javax.management=ALL-UNNAMED"
# InitialContext proxy generation requires deep reflection in javax.naming
Expand Down
2 changes: 2 additions & 0 deletions core-feature-pack/common/src/main/resources/content/bin/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ setDefaultModularJvmOptions() {
DEFAULT_MODULAR_JVM_OPTIONS="$DEFAULT_MODULAR_JVM_OPTIONS --add-opens=java.base/java.util=ALL-UNNAMED"
# Needed for marshalling of concurrent collections
DEFAULT_MODULAR_JVM_OPTIONS="$DEFAULT_MODULAR_JVM_OPTIONS --add-opens=java.base/java.util.concurrent=ALL-UNNAMED"
# Needed for marshalling of annotations
DEFAULT_MODULAR_JVM_OPTIONS="$DEFAULT_MODULAR_JVM_OPTIONS --add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED"
# EE integration with sar mbeans requires deep reflection in javax.management
DEFAULT_MODULAR_JVM_OPTIONS="$DEFAULT_MODULAR_JVM_OPTIONS --add-opens=java.management/javax.management=ALL-UNNAMED"
# InitialContext proxy generation requires deep reflection in javax.naming
Expand Down
1 change: 1 addition & 0 deletions host-controller/src/main/java/org/jboss/as/host/controller/jvm/JvmType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public final class JvmType {
modularJavaOpts.add("--add-opens=java.base/java.security=ALL-UNNAMED");
modularJavaOpts.add("--add-opens=java.base/java.util=ALL-UNNAMED");
modularJavaOpts.add("--add-opens=java.base/java.util.concurrent=ALL-UNNAMED");
modularJavaOpts.add("--add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED");
modularJavaOpts.add("--add-opens=java.management/javax.management=ALL-UNNAMED");
modularJavaOpts.add("--add-opens=java.naming/javax.naming=ALL-UNNAMED");
DEFAULT_MODULAR_JVM_ARGUMENTS = Collections.unmodifiableList(modularJavaOpts);
Expand Down
2 changes: 1 addition & 1 deletion ...oller/src/test/java/org/jboss/as/host/controller/ManagedServerBootCmdFactoryTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public void testGetServerLaunchCommand() throws UnknownHostException {
List<String> result = instance.getServerLaunchCommand();
MatcherAssert.assertThat(result.size(), is(notNullValue()));
if (result.size() > 18) {
MatcherAssert.assertThat(result.size(), is(getJavaVersion() <= 12 ? 34 : 33)); // for condition see WFCORE-4296 - java.base/com.sun.net.ssl.internal.ssl isn't available since JDK13
MatcherAssert.assertThat(result.size(), is(getJavaVersion() <= 12 ? 35 : 34)); // for condition see WFCORE-4296 - java.base/com.sun.net.ssl.internal.ssl isn't available since JDK13
} else {
MatcherAssert.assertThat(result.size(), is(18));
}
Expand Down
Loading