Open
Conversation
we should probs pull in x11 from bcr? tbh probably imgui/glfw from bcr too
auscompgeek
commented
Nov 22, 2025
Comment on lines
+81
to
+87
| # TODO(davo): update version after the next release of toolchains_llvm after 1.5.0 | ||
| http_archive( | ||
| name = "toolchains_llvm", | ||
| integrity = "sha256-Ht0UsdgsySFX+H7AU3TS992uZr8nV5TP60lADgKeP7s=", | ||
| strip_prefix = "toolchains_llvm-cebf1ed19db1521bcaae489a40dd736d50e9302f", | ||
| url = "https://github.com/bazel-contrib/toolchains_llvm/archive/cebf1ed19db1521bcaae489a40dd736d50e9302f.tar.gz", | ||
| ) |
Member
Author
There was a problem hiding this comment.
There's no toolchains_llvm release that supports the extra_*_flags parameters yet.
auscompgeek
added
the
build
Rebuilding the world requires more disk space.
Contributor
|
libtinfo5 is a library you can install (or patch into the llvm install) on 22.04. |
auscompgeek
force-pushed
the
llvm-toolchain
branch
from
b3c4bdd to
3ab7b31
Compare
auscompgeek
commented
Nov 22, 2025
| "darwin-aarch64": CONLY_FLAGS, | ||
| "darwin-x86_64": CONLY_FLAGS, | ||
| "linux-aarch64": CONLY_FLAGS, | ||
| "linux-x86_64": CONLY_FLAGS, |
Member
Author
There was a problem hiding this comment.
@AustinSchuh was there a particular reason bazel-contrib/toolchains_llvm#435 doesn't allow specifying a global conly_flags default with the empty string key like the other params?
Contributor
There was a problem hiding this comment.
No reason other than it probably didn't exist when that code was originally written 6 years ago.
AustinSchuh
approved these changes
Nov 22, 2025
Contributor
|
Bazel bits look good. In general, I'm a big clang fan, but I can't judge if that is good for this project or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls a hermetic LLVM toolchain into the Bazel workspace, for use in our Linux x86-64 builds. This removes our dependency on the host OS C++ toolchain, and hence makes building in a container largely redundant.
Since we no longer build in a container, this also frees up some disk space for our CI builds, however this is somewhat displaced by the size of the toolchain download.
Note that this doesn't register the toolchain with an isolated sysroot, so this now relies on the host image for its sysroot.