Improve publish-directory docs#541
Merged
ce10-sanger merged 1 commit intowtsi-npg:develfrom Apr 15, 2026
Merged
Conversation
jmtcsngr
reviewed
Apr 15, 2026
| "Optional, defaults to none. " | ||
| "May be used multiple times to add read permissions for multiple groups. " | ||
| "For new items, adds read access in addition to any inherited permissions. " | ||
| "For existing items, in addition to existing permissions. " |
Member
There was a problem hiding this comment.
Suggested change
| "For existing items, in addition to existing permissions. " | |
| "For existing items, in addition to existing (explicit and inherited) permissions. " |
Just wondering about the wording, but I don't disagree with your version.
Contributor
Author
There was a problem hiding this comment.
Discussed in office. Inheritance is creation only so we decided not to make this change
jmtcsngr
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.