Skip to content

Improve publish-directory docs #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ce10-sanger merged 1 commit into from
Apr 15, 2026
Merged

Improve publish-directory docs #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/npg_irods/cli/publish_directory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,12 @@

parser.add_argument(
"--group",
help="iRODS group to have read access. Optional, defaults to none. "
help="Add read access for the given iRODS group. "
"Optional, defaults to none. "
"May be used multiple times to add read permissions for multiple groups. "
"For new items, adds read access in addition to any inherited permissions. "
"For existing items, in addition to existing permissions. "
Copy link
Copy Markdown
Member

@jmtcsngr jmtcsngr Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"For existing items, in addition to existing permissions. "
"For existing items, in addition to existing (explicit and inherited) permissions. "

Just wondering about the wording, but I don't disagree with your version.

Copy link
Copy Markdown
Contributor Author

@ce10-sanger ce10-sanger Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in office. Inheritance is creation only so we decided not to make this change

"Unless explicitly specified, public permissions are removed. " # See ADR 1
Comment thread
ce10-sanger marked this conversation as resolved.
"Zone may be specified with #zone suffix, otherwise inferred from collection.",
type=str,
action="append",
Expand Down