XWIKI-24221: Same uploaded image is set for all attachmentSelector used in the same form#5386
Open
mathpce wants to merge 3 commits intoxwiki:masterfrom
Open
XWIKI-24221: Same uploaded image is set for all attachmentSelector used in the same form#5386mathpce wants to merge 3 commits intoxwiki:masterfrom
mathpce wants to merge 3 commits intoxwiki:masterfrom
Conversation
…d in the same form * only edit the property-reference value associated with the clicked AttachmentSelector button
michitux
reviewed
Apr 14, 2026
…ed in the same form * add escaping of propert name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-24221
Changes
Description
The property reference is used to identify the proper input in the form. So only this input will be updated when the attachment is uploaded, instead of all the ones in the same form.
Clarifications
The property reference is a mandatory parameter of the macro, so it should be a good way to identify the input.
Executed Tests
I have built xwiki-platform/xwiki-platform-core/xwiki-platform-attachment with
mvn clean installsuccessfully.