Skip to content

XWIKI-24221: Same uploaded image is set for all attachmentSelector used in the same form #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mathpce wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −1
Open

XWIKI-24221: Same uploaded image is set for all attachmentSelector used in the same form #5386

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6830d9
XWIKI-24221 Same uploaded image is set for all attachmentSelector use…
mathpce Apr 13, 2026
e4b1077
Merge branch 'xwiki:master' into master
mathpce Apr 13, 2026
031b46d
XWIKI-24221: Same uploaded image is set for all attachmentSelector us…
mathpce Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...m-attachment/xwiki-platform-attachment-ui/src/main/resources/XWiki/AttachmentSelector.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,7 @@ $xwiki.jsx.use($attachmentPickerDocName)
function uploadTemporaryAttachment() {
// Require jquery locally until we are able to fully migrate this code away from prototype.
const form = this.property.up('form');
var propertyName = this.property.down('.property-reference').name;
require(['jquery'], function ($) {
const data = new FormData();
const uploadedFile = $('#attachfile')[0].files[0];
Expand Down Expand Up @@ -510,7 +511,7 @@ $xwiki.jsx.use($attachmentPickerDocName)
.prop('type', 'hidden')
.prop('name', 'uploadedFiles')
.prop('value', response.fileName))
$(form).find('input[type="hidden"].property-reference').prop('value', response.fileName);
$(form).find(`input[type="hidden"].property-reference[name="${propertyName}"]`).prop('value', response.fileName);
Comment thread
mathpce marked this conversation as resolved.
Outdated
this.updateAttachment(response.fileName, response.url);
this.dialog.closeDialog();
}.bind(this)).fail(function () {
Expand Down