Chore: Applications action helpers#139
Open
iLLiCiTiT wants to merge 20 commits into
Open
Conversation
Member
Unfinished PR description? :) |
Member
Author
|
It was fast made PR for ftrack actions, can be done better with #151 . |
be288a6 to
77ae69b
Compare
# Conflicts: # server/actions.py
Member
|
Dumb question: is it still relevant when #151 is merged? |
Member
Author
Yes, this is extending it, that PR just added the method for one version of applications addon, but you still have to figure out which version should be used. There also are not api methods client side to get the information, which is what is needed for ftrack actions. |
Member
Member
Author
Don't know if you have |
Member
Member
Author
Will take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Changelog Description
Added helper functions to get list of available application actions for a given context.
Additional review information
These functions can be used to receive possible actions with all necessary information for a certain context. This will be used in ftrack addon. Also affects existing function
get_applications_for_contextwhich returns list of available application names.The new api functions can be used by other plugins. The implementation does handle project bundles on it's own and auto-resolves the settings for addons that don't have the api methods implemented yet.
Testing notes: