Track original bundle state in bundle.updated event#874
Open
martastain wants to merge 1 commit into
Open
Conversation
1 task
martastain
added
the
type: enhancement
BigRoy
reviewed
Mar 23, 2026
BigRoy
left a comment
BigRoy
left a comment
Member
There was a problem hiding this comment.
I personally preferred the newValue and originalValue payload that settings changes e.g. have because it's less duplication of is and was entries.
Also, I'm not sure this event really gives me the input I'd really be looking for quickly. Because what I'd really love to actually know is... that if this bundle is set to production - what was the previous production bundle: None or old-bundle-name.
🤔
However, other than that - this does work fine, however it does provide relatively limited data that I think you're often not too concerned about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the event dispatch logic in the
update_bundlefunction to provide more detailed information about bundle state changes. It introduces tracking of previous bundle states and ensures that these are included in the event summary, improving traceability for updates.Enhancements to event dispatch and bundle state tracking:
wasProduction,wasStaging,wasArchived) to the event summary