Skip to content

Track original bundle state in bundle.updated event #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martastain wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Track original bundle state in bundle.updated event #874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions api/bundles/bundles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,10 @@ async def update_bundle(
is_archived=row["is_archived"],
)

was_production = bundle.is_production
was_staging = bundle.is_staging
was_archived = bundle.is_archived

if patch.is_archived and (bundle.is_production or bundle.is_staging):
raise BadRequestException(
"Cannot archive bundle that is production or staging"
Expand Down Expand Up @@ -432,21 +436,26 @@ async def update_bundle(
if patch.is_production is not None or patch.is_staging is not None or patch.addons:
await AddonLibrary.clear_addon_list_cache()

summary = {
"name": bundle_name,
"changedFields": patch.get_changed_fields(),
"isProduction": bundle.is_production,
"isStaging": bundle.is_staging,
"isArchived": bundle.is_archived,
"isDev": bundle.is_dev,
"isProject": bundle.is_project,
"wasProduction": was_production,
"wasStaging": was_staging,
"wasArchived": was_archived,
}

await EventStream.dispatch(
"bundle.updated",
sender=sender,
sender_type=sender_type,
user=user.name,
description=patch.get_changes_description(bundle_name),
summary={
"name": bundle_name,
"changedFields": patch.get_changed_fields(),
"isProduction": bundle.is_production,
"isStaging": bundle.is_staging,
"isArchived": bundle.is_archived,
"isDev": bundle.is_dev,
"isProject": bundle.is_project,
},
summary=summary,
payload=data,
)

Expand Down
Loading