Skip to content

Allow integrator to take repre files with a single file as string instead of list#1839

Open
moonyuet wants to merge 3 commits into
developfrom
bugfix/YN-0632--Core--Allow-integrator-to-take-repre-files-with-single-file-as-a-List-#1777
Open

Allow integrator to take repre files with a single file as string instead of list#1839
moonyuet wants to merge 3 commits into
developfrom
bugfix/YN-0632--Core--Allow-integrator-to-take-repre-files-with-single-file-as-a-List-#1777

Conversation

@moonyuet

@moonyuet moonyuet commented May 18, 2026

Copy link
Copy Markdown
Member

Changelog Description

This PR is to allow integrator to take repre files with a single file as string instead of list
Fix #1836

Additional info

Marked it as draft for the discussion.

Testing notes:

  1. Create Render
  2. Publish both local/farm rendering

@moonyuet moonyuet self-assigned this May 18, 2026
@moonyuet moonyuet added type: bug Something isn't working sponsored This is directly sponsored by a client or community member labels May 18, 2026
@ynbot ynbot added the size/XS label May 18, 2026
@moonyuet moonyuet requested a review from LiborBatek May 18, 2026 08:30
@moonyuet moonyuet marked this pull request as ready for review May 18, 2026 08:33
@iLLiCiTiT

iLLiCiTiT commented Jun 18, 2026

Copy link
Copy Markdown
Member

I do remember we were discussing this and the result was that we should not allow this and we should fix the source of the issue instead. Or am I wrong? Do you remember @BigRoy ?

@BigRoy

BigRoy commented Jun 18, 2026

Copy link
Copy Markdown
Member

I do remember we were discussing this and the result was that we should not allow this and we should fix the source of the issue instead. Or am I wrong? Do you remember @BigRoy ?

You are not wrong - but it was for the initial hotfix for a particular case which was fixed here: #1836

However, long-term I believe we do want to 'simplify' things if we can. The question was more, that if we provide a single file in a list, whether we should still assume it to be a sequence (or 1 frame?) by the fact of it being a list or should we enforce it to be a frame-less file (as this PR would make it do; but that's also what the list[str] -> str on representation.files would already be doing.) So it wouldn't technically differ currently.

Anyway, we held off from allowing this fix initially due to the worry of edge cases it may somehow affect. But if we can reasonable avoid having to make it a str and perhaps even rely on it always being a list[str] it'd make the variable repre["files"] during publishing much more consistent.

This 'issue' though describes that single frame in list[str] should be a single frame sequence - which does mean that the fix done here is incorrect.

Anyway, main question is:

  • is there still reason for having files: str = "singlefile" and `files: list[str] = ["single_frame.exr"]"?
  • can we actually safely detect always the frame number from a single file in the list e.g. sh001.exr might refer to the shot number, not the frame number?

@iLLiCiTiT

Copy link
Copy Markdown
Member

I agree with the questions, but as you said this PR is not handling that and the question is out of scope of this PR (and the source issue) -> this is not the right place to ask the questions.

@antirotor

Copy link
Copy Markdown
Member

But this will break single frame sequences, right? I think we should communicate it somehow if that is the solution (even temporary one)

antirotor and others added 2 commits June 22, 2026 15:53
…-take-repre-files-with-single-file-as-a-List-#1777
…-take-repre-files-with-single-file-as-a-List-#1777
@jakubjezek001

Copy link
Copy Markdown
Member

I am not sure if this is related but there might be also case where single frames with slates will need to be published. It might be really rare use case. And it will in fact become two frame sequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS sponsored This is directly sponsored by a client or community member type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

YN-0632: Core: Allow integrator to take repre files with single file as a List

6 participants