[MISC] Fix PBD entities to properly add visual vertices to solver for BatchRendererCamera compatibility#2696
Conversation
…hRendererCamera compatibility
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44d22c5ddd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- ParticleEntity._add_to_solver() already calls _add_vverts_to_solver() when _need_skinning=True, which is the case for all PBD tet entities - The duplicate call caused redundant precomputation (pairwise distance matrix, pseudoinverse, kernel upload) with no functional benefit - PBDParticleEntity and SPHEntity pass need_skinning=False so they were not affected Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
|
@claude review |
AnalysisAfter investigation, this PR is currently a net-zero change.
The reason for the revert (documented in If the original issue (BatchRendererCamera not rendering PBD entities) is still open, the fix should be investigated at a different layer — the Closing this PR as the net change is zero and the fix belongs elsewhere. |
Summary
Fixed PBD entities to properly add visual vertices to solver for BatchRendererCamera compatibility.
Previously, PBD entities were not calling
_add_vverts_to_solver()in their_add_to_solver()method, which meant that visual vertices were not being added to the solver. This caused the BatchRendererCamera to fail when trying to render PBD entities because it couldn't find the visual vertex data.This fix ensures that PBD entities properly add their visual vertices to the solver, making them compatible with the BatchRendererCamera.
Testing