Skip to content

[MISC] Fix PBD entities to properly add visual vertices to solver for BatchRendererCamera compatibility #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vlordier wants to merge 3 commits into from
Closed

[MISC] Fix PBD entities to properly add visual vertices to solver for BatchRendererCamera compatibility #2696

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44d22c5
fix: PBD entities now properly add visual vertices to solver for Batc…
vlordier Apr 11, 2026
57eee9d
[BUG FIX] Remove duplicate _add_vverts_to_solver() call in PBD entity
vlordier Apr 11, 2026
4e4a86e
Merge branch 'main' into feature/pbd-batch-renderer-fix
vlordier Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions genesis/engine/entities/pbd_entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ def _add_to_solver(self):

self._kernel_add_uvs_and_faces_to_solver(uvs=uvs, faces=self._vfaces)

# Add visual vertices for skinning if needed
if self._need_skinning:
self._add_vverts_to_solver()
Comment thread
vlordier marked this conversation as resolved.
Outdated

@qd.kernel
def _kernel_add_uvs_and_faces_to_solver(
self,
Expand Down
Loading