OSOE-1284: Fix deprecations in common workflows - #672
Merged
Conversation
This was referenced Sep 5, 2026
This was referenced Sep 5, 2026
sarahelsaig
reviewed
Sep 7, 2026
Co-authored-by: Sára El-Saig <sara.el-saig@lombiq.com>
sarahelsaig
reviewed
Sep 7, 2026
sarahelsaig
enabled auto-merge
September 8, 2026 15:33
sarahelsaig
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #630 by removing the remaining Node.js 20 action runtimes from common workflows.
Validation: label regression tests passed; all changed YAML passed yamllint; changed workflows passed actionlint; git diff --check passed. Added Ubuntu and Windows CI tests for label handling and telemetry cleanup/artifact generation.
The pinned Twitter bundle passed 30 of 31 upstream scenarios under Node.js 24 using nock 14 for native-fetch mocking and Linux line-ending behavior on the Windows test host. The remaining scenario exposes an existing bundled-code mismatch: a preview of a tweet without a trailing newline includes the diff's "No newline at end of file" marker. The bundle is unchanged by this PR. No real X posts were made. The bundle also emits its existing dependency's punycode deprecation notice under Node.js 24; the deprecated action-runtime declaration is no longer used.
The pnpm/action-setup update is in the companion NodeJs-Extensions PR; the superproject PR updates the submodule pointer and consumes these branches. Telemetry no longer supports process traces or PR comments; see Docs/Workflows.md for migration details.
Companion PRs: Lombiq/NodeJs-Extensions#175 and Lombiq/Open-Source-Orchard-Core-Extensions#1334.
CI verification: Ubuntu and Windows label/telemetry smoke jobs passed and produced metrics artifacts; YAML, spelling, branch-reference, and PR validation checks passed. New PowerShell scripts also pass the repository's custom analyzer rules locally. The superproject allowlist permits the telemetry action, and its root-solution and NuGetTest build-and-test jobs passed with metrics artifacts uploaded. See https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/actions/runs/33988394245.
Nested-call regression: JSON secrets must be constructed as a single line in the caller. GitHub masks individual lines of multiline secrets before actions start; standalone braces otherwise corrupt Mermaid charts and their legends. Updated all ENVIRONMENT_VARIABLES_JSON examples to folded blocks with equally indented lines, documented the cause, and added a two-level reusable-workflow regression. Ubuntu and Windows jobs both passed, preserving chart braces while masking synthetic credentials and uploading metrics artifacts: https://github.com/Lombiq/GitHub-Actions/actions/runs/34058180250.
Cross-repository telemetry authentication: the three build-and-test workflows now pass github.token to telemetry instead of CHECKOUT_TOKEN. Telemetry lists jobs in the original caller repository; a PAT that can check out another private repository may not be able to read the caller's Actions run, resulting in a post-job 404. The checkout token remains unchanged. The caller's GITHUB_TOKEN needs actions:read, as documented. Verified token selection and checkout-token preservation in all three parsed workflows; yamllint, actionlint, and git diff --check pass.