Skip to content

test: Improve test coverage for tecDIR_FULL error in xrpld#6717

Closed
neti-soft-com wants to merge 1 commit intoXRPLF:developfrom
neti-soft-com:tecdir-full
Closed

test: Improve test coverage for tecDIR_FULL error in xrpld#6717
neti-soft-com wants to merge 1 commit intoXRPLF:developfrom
neti-soft-com:tecdir-full

Conversation

@neti-soft-com
Copy link
Copy Markdown
Collaborator

High Level Overview of Change

The main goal of this PR is to improve test coverage for the xrpld application.

With the recent ability to simulate the tecDIR_FULL error, we can now comprehensively cover all cases where this error is returned. Consequently, this PR modifies production code solely to remove the now-obsolete LCOV_EXCL_LINE comments.

Context of Change

This PR is enabled by the implementation of #5935.
Once completed, it will resolve issue #5969.

Type of Change

  • test: - The changes only affect unit tests.

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Test Plan

Verification is done by running the automated unit test suite.
Code coverage metrics will reflect the newly covered tecDIR_FULL error branches.

WIP Status & Future Tasks

Note: This PR is currently a Draft.
Pending tasks before marking as "Ready to merge":

  • Cover remaining edge cases.
  • Resolve existing merge conflicts.
  • Code and PR polishing.
  • Ensure all commits are squashed logically, follow the 50/72 formatting rule, and are signed via GPG.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

⚠️ This PR contains unsigned commits. To get your PR merged, please sign them. ⚠️

If only the most recent commit is unsigned, you can run:

  1. Amend the commit: git commit --amend --no-edit -n -S
  2. Overwrite the commit: git push --force-with-lease

If multiple commits are unsigned, you can run:

  1. Go into interactive rebase mode: git rebase --interactive HEAD~<NUM_OF_COMMITS>, where NUM_OF_COMMITS is the number of most recent commits that will be available to edit.
  2. Change "pick" to "edit" for the commits you need to sign, and then save and exit.
  3. For each commit, run: git commit --amend --no-edit -n -S
  4. Continue the rebase: git rebase --continue
  5. Overwrite the commit(s): git push --force-with-lease

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.
See use 1Password to sign your commits.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

This PR has conflicts, please resolve them in order for the PR to be reviewed.

@github-actions
Copy link
Copy Markdown

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant