Skip to content

refactor(component_state_monitor): replace topic state monitor by behavior path planner timeout#1779

Open
takam5f2 wants to merge 6 commits intoautowarefoundation:mainfrom
takam5f2:refactor/replace-topic_state_monitor-by-behavior_path_planner-timeout
Open

refactor(component_state_monitor): replace topic state monitor by behavior path planner timeout#1779
takam5f2 wants to merge 6 commits intoautowarefoundation:mainfrom
takam5f2:refactor/replace-topic_state_monitor-by-behavior_path_planner-timeout

Conversation

@takam5f2
Copy link
Copy Markdown
Contributor

@takam5f2 takam5f2 commented Mar 3, 2026

Description

Remove topic_state_monitor-based diagnostic entries that are now redundant, because behavior_path_planner internally monitors its input message timeouts (see autowarefoundation/autoware_universe#12075).

The following topic_state_monitor entries are removed from component_state_monitor config:

Domain Removed topic_state_monitor Reason
localization pose_twist_fusion_filter Monitored as odometry input by behavior_path_planner
map vector_map Monitored as vector map input by behavior_path_planner
perception traffic_signals Monitored as traffic signal input by behavior_path_planner
perception objects Monitored as perception objects input by behavior_path_planner
perception pointcloud Monitored as obstacle segmentation input by behavior_path_planner
planning route Monitored as route input by behavior_path_planner

How was this PR tested?

Setup before launch

cd /path/to/autoware
source install/setup.bash

cd /path/to/autoware/src/launcher/autoware_launch
gh pr checkout 1779 --repo autowarefoundation/autoware_launch

Launch Autoware with PSim.

source ~/autoware/install/setup.bash
ros2 launch autoware_launch planning_simulator.launch.xml map_path:=$HOME/autoware_map/sample-map-planning vehicle_model:=autoware_sample_vehicle sensor_model:=autoware_sample_sensor_kit

Run converter_node from diagnostic_graph_utils package.

ros2 run autoware_diagnostic_graph_utils converter_node

Run rqt_runtime_monitor

 ros2 run rqt_runtime_monitor rqt_runtime_monitor --ros-args -r diagnostics:=diagnostics_array

You'll find that /autoware/planning/behavior_path_planner/incoming_message_timeout is defined.
image

Notes for reviewers

None.

Effects on system behavior

Some topic_state_monitor will not run after this changes.

takam5f2 added 3 commits March 3, 2026 12:18
…path_planner timeout error

Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
…cs which are received by behavior_path_planner

Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
@github-actions github-actions bot added component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Mar 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takam5f2 takam5f2 marked this pull request as ready for review March 4, 2026 03:55
@takam5f2 takam5f2 self-assigned this Mar 4, 2026
- { path: $(dirname)/map.yaml }
- { path: $(dirname)/perception.yaml }
# You can create the perception.yaml in the same way as other configuration files.
# - { path: $(dirname)/perception.yaml }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep it as an empty file to minimize the differences with the fork repository?

Copy link
Copy Markdown
Contributor Author

@takam5f2 takam5f2 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isamu-takagi
Thank you for your feedback.

I have restored the perception.yaml file at 067887c.

I changed the percetion.yaml to let /autoware/perception notify ok always to clafiry the difference.
Do you think whether the change is acceptable?

takam5f2 added 2 commits March 4, 2026 19:25
Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
…lanner-timeout' of github.com:takam5f2/autoware_launch into refactor/replace-topic_state_monitor-by-behavior_path_planner-timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants