Skip to content

refactor(component_state_monitor): replace topic state monitor by control_exe_node timeout#1784

Draft
takam5f2 wants to merge 2 commits intoautowarefoundation:mainfrom
takam5f2:refactor/replace-topic-state-monitor-by_control_exe_node-timeout
Draft

refactor(component_state_monitor): replace topic state monitor by control_exe_node timeout#1784
takam5f2 wants to merge 2 commits intoautowarefoundation:mainfrom
takam5f2:refactor/replace-topic-state-monitor-by_control_exe_node-timeout

Conversation

@takam5f2
Copy link
Copy Markdown
Contributor

@takam5f2 takam5f2 commented Mar 5, 2026

Description

Remove topic_state_monitor-based diagnostic entries that are now redundant, because trajectory_follower_node internally monitors its input message timeouts (see autowarefoundation/autoware_universe#12082).

The following topic_state_monitor entries are removed from tier4_diagnostics config:

Domain Removed topic_state_monitor Reason
planning trajectory Monitored as trajectory input by trajectory_follower_node

A new diagnostic entry /autoware/control//incoming_message_timeout is added to control.yaml, which aggregates the trajectory_follower_node's incoming_message_timeout diagnostics.

How was this PR tested?

Setup before launch

cd /path/to/autoware
source install/setup.bash

cd /path/to/autoware/src/launcher/autoware_launch
gh pr checkout 1784 --repo autowarefoundation/autoware_launch

Launch Autoware with PSim.

source ~/autoware/install/setup.bash
ros2 launch autoware_launch planning_simulator.launch.xml map_path:=$HOME/autoware_map/sample-map-planning vehicle_model:=autoware_sample_vehicle sensor_model:=autoware_sample_sensor_kit

Run converter_node from diagnostic_graph_utils package.

ros2 run autoware_diagnostic_graph_utils converter_node

Run rqt_runtime_monitor

 ros2 run rqt_runtime_monitor rqt_runtime_monitor --ros-args -r diagnostics:=diagnostics_array

You'll find that /autoware/control//incoming_message_timeout is defined.
image

Notes for reviewers

Evaluator worked fine after merging this change.
https://evaluation.tier4.jp/evaluation/reports/f4b62541-3aef-5f8f-a3c0-824090a5d513?project_id=autoware_dev

Effects on system behavior

Some topic_state_monitor will not run after this changes.

takam5f2 added 2 commits March 5, 2026 19:47
…imeout

Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
…tor.

Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Mar 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2026

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takam5f2 takam5f2 changed the title refactor(): replace topic state monitor by control_exe_node timeout refactor(component_state_monitor): replace topic state monitor by control_exe_node timeout Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant