refactor(component_state_monitor): replace topic state monitor by control_exe_node timeout#1784
Draft
takam5f2 wants to merge 2 commits intoautowarefoundation:mainfrom
Conversation
…imeout Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
…tor. Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
topic_state_monitor-based diagnostic entries that are now redundant, becausetrajectory_follower_nodeinternally monitors its input message timeouts (see autowarefoundation/autoware_universe#12082).The following
topic_state_monitorentries are removed fromtier4_diagnosticsconfig:trajectoryA new diagnostic entry
/autoware/control//incoming_message_timeoutis added tocontrol.yaml, which aggregates thetrajectory_follower_node'sincoming_message_timeoutdiagnostics.How was this PR tested?
Setup before launch
Launch Autoware with PSim.
Run
converter_nodefromdiagnostic_graph_utilspackage.Run
rqt_runtime_monitorYou'll find that

/autoware/control//incoming_message_timeoutis defined.Notes for reviewers
Evaluator worked fine after merging this change.
https://evaluation.tier4.jp/evaluation/reports/f4b62541-3aef-5f8f-a3c0-824090a5d513?project_id=autoware_dev
Effects on system behavior
Some
topic_state_monitorwill not run after this changes.