Skip to content

fix(tier4_map_launch): add allow_substs="true" to map launcher parameter including#1821

Open
paulsohn wants to merge 2 commits intoautowarefoundation:mainfrom
paulsohn:sohn/param_allow_substs_true
Open

fix(tier4_map_launch): add allow_substs="true" to map launcher parameter including#1821
paulsohn wants to merge 2 commits intoautowarefoundation:mainfrom
paulsohn:sohn/param_allow_substs_true

Conversation

@paulsohn
Copy link
Copy Markdown
Contributor

@paulsohn paulsohn commented Apr 17, 2026

Description

As pointcloud_map_loader.param.yaml (substitutions for $(var pointcloud_map_loader_param_path)) itself uses substitutions:

/**:
  ros__parameters:
    enable_whole_load: true
    enable_downsampled_whole_load: false
    enable_partial_load: true
    enable_selected_load: false

    # only used when downsample_whole_load enabled
    leaf_size: 3.0 # downsample leaf size [m]
    pcd_paths_or_directory: [$(var pointcloud_map_path)] # Path to the pointcloud map file or directory
    pcd_metadata_path: $(var pointcloud_map_metadata_path) # Path to pointcloud metadata file

we need allow_substs="true" to activate the substitutions inside the parameter file.
Similar to lanelet2_map_loader.param.yaml.

Related link: autowarefoundation/autoware_universe#6250
Perception is already using the same allow_substs="true" config.

How was this PR tested?

Not directly.

This issue was revealed when I was working on semantics improvement of my pre-build launcher resolver tool roscope ( paulsohn/roscope#46 ) and by the same tool I've confirmed this patch gives the correct parameters.

Notes for reviewers

None.

Effects on system behavior

None, or fix the PCD map loading issue.

Signed-off-by: Taeseung Sohn <taeseung.sohn@tier4.jp>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2026

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Apr 17, 2026
@paulsohn paulsohn changed the title chore(tier4_map_launch): add allow_substs="true" to map launcher parameter including fix(tier4_map_launch): add allow_substs="true" to map launcher parameter including Apr 17, 2026
Comment thread tier4_universe_launch/tier4_map_launch/launch/map.launch.xml Outdated
Comment thread tier4_universe_launch/tier4_map_launch/launch/map.launch.xml Outdated
Comment thread tier4_universe_launch/tier4_map_launch/launch/map.launch.xml Outdated
Signed-off-by: Taeseung Sohn <taeseung.sohn@tier4.jp>
@paulsohn paulsohn requested a review from YamatoAndo April 17, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:map Map creation, storage, and loading. (auto-assigned) run:build-and-test-differential

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants