fix(tier4_control_launch): add allow_substs="true" to control launcher parameter including#1822
Open
paulsohn wants to merge 2 commits intoautowarefoundation:mainfrom
Open
Conversation
Signed-off-by: Taeseung Sohn <taeseung.sohn@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Taeseung Sohn <taeseung.sohn@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As
vehicle_cmd_gate.param.yamluses substitution:we need
allow_substs="true"to activate the substitutions inside the parameter file.We already have many param files for control, so instead of attaching
allow_substs="true"for every param file reference at once (unlike #1821 , where 2 out of 3<param from />required this) I want to add this attribute for only where it's needed for now, and apply to other files in a separate PR.Related link: autowarefoundation/autoware_universe#6250
Perception is already using the same
allow_substs="true"config.How was this PR tested?
Not directly.
This issue was revealed when I was working on semantics improvement of my pre-build launcher resolver tool roscope ( paulsohn/roscope#46 ) and by the same tool I've confirmed this patch gives the correct parameters.
Notes for reviewers
None.
Effects on system behavior
None, or fix
check_external_emergency_heartbeatsubstitution skipping.