feat(lidar_marker_localizer): average intensity guard on lidar marker localizer#12003
Draft
Motsu-san wants to merge 41 commits intoautowarefoundation:mainfrom
Draft
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12003 +/- ##
===========================================
- Coverage 18.36% 2.83% -15.53%
===========================================
Files 1849 975 -874
Lines 128005 61057 -66948
Branches 45554 9997 -35557
===========================================
- Hits 23507 1733 -21774
+ Misses 85042 59198 -25844
+ Partials 19456 126 -19330
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e90331b to
379448c
Compare
Contributor
|
@Motsu-san cc @KYabuuchi @TaikiYamada4 @YamatoAndo As we decided to migrate tier4 launchers into autoware_launch repository, |
379448c to
9995cda
Compare
Contributor
Author
|
@paulsohn Thank you for your notice! The conflict has been resolved. |
1ffd802 to
a1d6f4d
Compare
a1d6f4d to
f73bc20
Compare
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
for using PointType in both PointXYZIRC and PointXYZIRADRT Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
- Add check to skip empty ring pointclouds in detect_landmarks - Prevent unnecessary processing and possible errors when a ring has no points Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
- Enable generic processing for multiple point cloud types - Prepare for future multi-LiDAR marker localization support Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com> # Conflicts: # launch/tier4_localization_launch/launch/localization.launch.xml # launch/tier4_localization_launch/launch/pose_twist_estimator/lidar_marker_localizer.launch.xml # launch/tier4_localization_launch/launch/pose_twist_estimator/pose_twist_estimator.launch.xml
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
To indicate the contributor's affiliation Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
…ramework Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
If enabled, it may cause instability in the z-direction in the case of driving on level road Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
…ints) Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
to reject false positives from high-intensity surfaces Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
- Added description of the average intensity check feature to the Detection Algorithm section of README.md - Added the max_average_intensity_threshold parameter to schema.json Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
f73bc20 to
018bcb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a feature to the LiDAR marker localizer that skips pattern matching when the average intensity exceeds a threshold. This prevents false detections from high-intensity surfaces (such as walls) that directly face the LiDAR receiver.
Feature Addition
max_average_intensity_threshold0.0(check is disabled when 0.0 or less)Implementation Details
Parameter declaration (
lidar_marker_localizer.hpp,lidar_marker_localizer.cpp)max_average_intensity_thresholdparameter asdoubletypeAverage intensity check logic (
lidar_marker_localizer.cpp)max_average_intensity_threshold > 0.0and average intensity is greater than or equal to the thresholdConfiguration file update (
lidar_marker_localizer.param.yaml)Test Addition
Added three test cases:
AverageIntensityBelowThresholdAverageIntensityAboveThresholdAverageIntensityCheckDisabledmax_average_intensity_thresholdis 0.0 or lessUsage Example
Impact
0.0, so no impact on existing configurationsRelated links
The following pull-request must be merged simultaneously.
autowarefoundation/autoware_launch#1741
How was this PR tested?
colcon test --packages-select autoware_lidar_marker_localizerand confirm the resultcolcon test-result --all --verbose --test-result-base build/autoware_lidar_marker_localizerpose_source:=ndt_lidar-markeroption and replay Sample rosbag and map .max_average_intensity_thresholdvalue to 1.0 inautoware_launch/config/localization/lidar_marker_localizer/top_left/lidar_marker_localizer.param.yamlandautoware_launch/config/localization/lidar_marker_localizer/top_right/lidar_marker_localizer.param.yamlNotes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.