Update examples to use Image::new_target_texture instead of manual image creation when possible#23715
Open
doonv wants to merge 2 commits intobevyengine:mainfrom
Open
Update examples to use Image::new_target_texture instead of manual image creation when possible#23715doonv wants to merge 2 commits intobevyengine:mainfrom
Image::new_target_texture instead of manual image creation when possible#23715doonv wants to merge 2 commits intobevyengine:mainfrom
Conversation
…image creation when possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix #19101. (Kinda, this is not the exact solution proposed in that issue, but it still shortens most of the examples)
Solution
Most of the images created in examples are for use in render targets.
Image::new_target_textureis made for exactly that and significantly shortens the image creation process.Testing
I tested all the examples I changed and they seem to work fine.
btw for some reason most of the examples use
TextureFormat::Bgra8UnormSrgbwhile the documentation forImage::new_target_texturerecommendsTextureFormat::Rgba8UnormSrgbfor SDR images. What's up with that?