Open
Conversation
TextInputMeasure is updated to control size on both axis. Now has a width field as well as height, and both are optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Horizontal equivalent of the
visible_linesoption.Allow users to set the width of a text input widget by number of glyphs. Or for proportional fonts, where the glyph widths are non-uniform, it would use a multiple of the advance width for "0".
Solution
visible_width: Option<f32>field onEditableText.TextInputMeasurenow has both a width and height field and both areOption<f32>.update_editable_text_content_sizecalculates the width ifvisible_widthisSome.visible_width(if set) and the current scale factor.Testing
I altered the hex input in the
feathersexample to so it's sized to fit 10 characters (includes space for the cursor).