Add bevy_error! and bail! macros to BevyError#23720
Open
loreball wants to merge 1 commit intobevyengine:mainfrom
Open
Add bevy_error! and bail! macros to BevyError#23720loreball wants to merge 1 commit intobevyengine:mainfrom
bevy_error! and bail! macros to BevyError#23720loreball wants to merge 1 commit intobevyengine:mainfrom
Conversation
Contributor
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
Contributor
Author
|
I have no idea how this code could change the rendering. I'm guessing it's a false alarm since image upload failed. It's that or a miscompilation. |
urben1680
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
These macros were originally part of #23684 but were removed to help the pr cross the finish line.
Solution
Reintroduce and discuss them here.
Testing
2 testcases to prove the expanded code compiles.
bevy_ecshas been expanded with 2 macros to simplify creation ofBevyErrors.