Clarify Image::set_color_at docs about R formats#23729
Open
lkolbly wants to merge 1 commit intobevyengine:mainfrom
Open
Clarify Image::set_color_at docs about R formats#23729lkolbly wants to merge 1 commit intobevyengine:mainfrom
lkolbly wants to merge 1 commit intobevyengine:mainfrom
Conversation
kfc35
added
C-Docs
andriyDev
approved these changes
Apr 9, 2026
andriyDev
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The
Image::set_color_atfunction converts the color to grayscale, and then uses the luminance as the value for the R channel.Solution
This behaviour is intentional according to discussion in the original PR (#10392), therefore rather than change the behaviour to this PR changes the docs.
(
Image::get_color_at's docs are already correct on this matter)Testing
I did not test this change.