Skip to content

Allow fallback error handlers to queue commands - #25288

Open
0xEgao wants to merge 1 commit into
bevyengine:mainfrom
0xEgao:fallback-error
Open

Allow fallback error handlers to queue commands#25288
0xEgao wants to merge 1 commit into
bevyengine:mainfrom
0xEgao:fallback-error

Conversation

@0xEgao

@0xEgao 0xEgao commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Objective

Fixes #24821.

Solution

  • Pass Commands to ErrorHandler and return it from the handler.
  • Apply commands queued by error handlers across executors, observers, combinators, and command error paths.
  • Preserve existing scheduling behavior when no error occurs.
  • Add a set_error_handler doc example demonstrating how to send AppExit.

@alice-i-cecile

Copy link
Copy Markdown
Member

I really want a feature like this, but this might have surprising performance implications. Can you please benchmark this?

@0xEgao

0xEgao commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

I really want a feature like this, but this might have surprising performance implications. Can you please benchmark this?

Yeah sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow FallbackErrorHandler to send AppExit

2 participants