Extracted UI layout - #25289
Open
ickshonpe wants to merge 96 commits into
Open
Conversation
Added rough geometry extraction impl.
added debug system
UiMaterial rendering function now.
Shadow geometry is now resolved in prepare_shadows.
…the gradient geometry is resolved in prepare, not extraction.
… Extraction buffer types
…xt, EditableText doesn't use Text
…ng glyph layout, only do it for the ones in the current glyph layout, not the whole batch
ickshonpe
added
A-Rendering
ickshonpe
added
the
C-Performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Extract the UI layout geometry once per node, not for each different UI content component.
Solution
Got carried away with this, possibly too much to review. To get the full benefits from the extraction system changes required rewriting the prepare systems as well. That became a massive mess and tidying it up needed even more changes.
New
extract_layoutmodule.Has a system
extract_ui_layout. On changes it extracts all the common UI layout properties toExtractedUiNodeLayouts.Other extraction systems now only extract content and style components. They can't resolve any responsive coords or geometry as they don't have access to the layout, that has to be done in prepare now.
The text layout extraction is quite clumsy and does a lot of allocations. The gradients rendering as well.
The UI debug overlay is just outlines, so it is now queued as a single phase item.
There are gratuitous changes to batching and image handling in
prepare_uinodes. I don't know how wise they are exactly, but performance is significantly better. Possibly redundant with bindless though.Still need to fix:
TextSection'TextColor`s don't work, they are just white.Testing
yellow this PR, main red.
frames:
queue_uinodes:
prepare_uinodes:
