fix(hal/vulkan): Use queue family index modified by device open callback - #9965
Merged
Merged
Conversation
ErichDonGubler
approved these changes
Jul 30, 2026
ErichDonGubler
left a comment
Member
There was a problem hiding this comment.
LGTM. I have some questions and suggestions, but nothing that seems significant enough to block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small thing I noticed.
family_infowas not routed through the callback, so if the callback did modifyqueue_create_infos, an incorrect index could be used.Also updates the doc comment for
CreateDeviceCallbackArgs::queue_create_infos.Testing
Untested
Squash or Rebase? Squash
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.