Skip to content

fix(hal/vulkan): Use queue family index modified by device open callback - #9965

Merged
ErichDonGubler merged 2 commits into
gfx-rs:trunkfrom
andyleiserson:vulkan-device-hook
Aug 3, 2026
Merged

fix(hal/vulkan): Use queue family index modified by device open callback#9965
ErichDonGubler merged 2 commits into
gfx-rs:trunkfrom
andyleiserson:vulkan-device-hook

Conversation

@andyleiserson

Copy link
Copy Markdown
Contributor

Just a small thing I noticed. family_info was not routed through the callback, so if the callback did modify queue_create_infos, an incorrect index could be used.

Also updates the doc comment for CreateDeviceCallbackArgs::queue_create_infos.

Testing
Untested

Squash or Rebase? Squash

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

@ErichDonGubler ErichDonGubler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have some questions and suggestions, but nothing that seems significant enough to block.

Comment thread wgpu-hal/src/vulkan/adapter.rs Outdated
Comment thread wgpu-hal/src/vulkan/adapter.rs Outdated
Comment thread wgpu-hal/src/vulkan/adapter.rs
@ErichDonGubler ErichDonGubler self-assigned this Jul 30, 2026
@ErichDonGubler ErichDonGubler added type: bug Something isn't working backend: vulkan Issues with Vulkan labels Jul 30, 2026
@ErichDonGubler
ErichDonGubler merged commit 9c05b85 into gfx-rs:trunk Aug 3, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend: vulkan Issues with Vulkan type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants