Skip to content

fix(hal/vulkan): Use queue family index modified by device open callback #9965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErichDonGubler merged 2 commits into from
Aug 3, 2026
+9 −7
Merged

fix(hal/vulkan): Use queue family index modified by device open callback #9965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e97ea08
fix(hal/vulkan): Use queue family index modified by device open callback
andyleiserson Jul 28, 2026
58883ed
Remove TODO and use `vec![]`
andyleiserson Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions wgpu-hal/src/vulkan/adapter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3011,11 +3011,10 @@ impl super::Adapter {
let mut enabled_extensions = self.required_device_extensions(features);
let mut enabled_phd_features = self.physical_device_features(&enabled_extensions, features);

let family_index = 0; //TODO
let family_info = vk::DeviceQueueCreateInfo::default()
.queue_family_index(family_index)
.queue_priorities(&[1.0]);
let mut family_infos = Vec::from([family_info]);
let default_family_index = 0;
let mut family_infos = vec![vk::DeviceQueueCreateInfo::default()
.queue_family_index(default_family_index)
.queue_priorities(&[1.0])];

let mut pre_info = vk::DeviceCreateInfo::default();

Expand Down Expand Up @@ -3069,7 +3068,7 @@ impl super::Adapter {
features,
limits,
memory_hints,
family_info.queue_family_index,
family_infos[0].queue_family_index,
Comment thread
ErichDonGubler marked this conversation as resolved.
0,
)
}
Expand Down
5 changes: 4 additions & 1 deletion wgpu-hal/src/vulkan/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1710,7 +1710,10 @@ where
pub extensions: &'arg mut Vec<&'static CStr>,
/// The physical device features to enable. You may enable features, but must not disable any.
pub device_features: &'arg mut PhysicalDeviceFeatures,
/// The queue create infos for the device. You may add or modify queue create infos as needed.
/// The queue create infos for the device. You may substitute a different queue, but:
/// 1. Any queue you provide must be compatible with `wgpu`'s usage,
/// 2. You must not leave the vector empty,
/// 3. `wgpu` currently only uses the first entry.
pub queue_create_infos: &'arg mut Vec<vk::DeviceQueueCreateInfo<'pnext>>,
/// The create info for the device. You may add or modify things in the pnext chain, but
/// do not turn features off. Additionally, do not add things to the list of extensions,
Expand Down