Fix TigOpenFileWithCommit not using default args#35
Open
maxigit wants to merge 1 commit intoiberianpig:masterfrom
Open
Fix TigOpenFileWithCommit not using default args#35maxigit wants to merge 1 commit intoiberianpig:masterfrom
maxigit wants to merge 1 commit intoiberianpig:masterfrom
Conversation
iberianpig
reviewed
Sep 25, 2021
Comment on lines
+39
to
+40
| \ call call('tig_explorer#open_file_with_commit', | ||
| \ slice(["<bang>",<q-mods>,<f-args>]+['','',''],0,5)) |
Owner
There was a problem hiding this comment.
not working on Vim 8.1 and NVIM v0.4.3
These errors are meaning,
Unknown function: slice
Invalid argument: call
Contributor
Author
|
I'm just trying to find a way to fix a regression which has been introduced to remove the use of default value in function arguments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TigOpenFileWithCommit broken if not all arguments are given.