Skip to content

Fix TigOpenFileWithCommit not using default args #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxigit wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −4
Open

Fix TigOpenFileWithCommit not using default args #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions autoload/tig_explorer.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ endfunction
" Open a file for the given commit
" Usefull when editing file from tree or blame view
function! tig_explorer#open_file_with_commit(diff, mods, commit, file, lineno)
let commit = get(a:, 'commit', 'HEAD')
let file = get(a:, 'file', '')
let lineno = get(a:, 'lineno', 0)
let commit = a:commit ?? 'HEAD'
let file = a:file
let lineno = a:lineno ?? 0

let file0 = ''
" if no file is provided use the current one
Expand Down
3 changes: 2 additions & 1 deletion plugin/tig_explorer.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ command! TigStatus
\ call tig_explorer#status()

command! -bang -nargs=* TigOpenFileWithCommit
\ call tig_explorer#open_file_with_commit("<bang>",<q-mods>,<f-args>)
\ call call('tig_explorer#open_file_with_commit',
\ slice(["<bang>",<q-mods>,<f-args>]+['','',''],0,5))
Comment on lines +39 to +40
Copy link
Copy Markdown
Owner

@iberianpig iberianpig Sep 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working on Vim 8.1 and NVIM v0.4.3

Image from Gyazo

These errors are meaning,

Unknown function: slice
Invalid argument: call


let &cpoptions = s:save_cpo
unlet s:save_cpo
Expand Down