Skip to content

fix(ci): add missing lfx build step to cross-platform workflow_dispatch - #12524

Merged
vjgit96 merged 1 commit into
release-1.9.0from
fix/cross-platform-lfx-build
Apr 6, 2026
Merged

fix(ci): add missing lfx build step to cross-platform workflow_dispatch#12524
vjgit96 merged 1 commit into
release-1.9.0from
fix/cross-platform-lfx-build

Conversation

@vjgit96

@vjgit96 vjgit96 commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

The build-if-needed job (used by workflow_dispatch) was missing the lfx package build, causing all cross-platform tests to fail with:

'No solution found: lfx>=0.4.0 required but only <=0.3.4 available'

Changes:

  • Build lfx wheel in build-if-needed job
  • Upload lfx artifact (adhoc-dist-lfx)
  • Add lfx-artifact-name to job outputs
  • Update all test jobs to fallback to build-if-needed outputs for lfx artifact (matching existing base/main pattern)

@vjgit96
vjgit96 requested a review from Adam-Aghili April 6, 2026 18:13
@coderabbitai

coderabbitai Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cd1293eb-933e-4240-ad5d-419edce38b09

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cross-platform-lfx-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vjgit96
vjgit96 requested a review from jordanrfrazier April 6, 2026 18:13
@github-actions github-actions Bot added the bug Something isn't working label Apr 6, 2026

@Adam-Aghili Adam-Aghili left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just adding lfx to build if needed

The build-if-needed job (used by workflow_dispatch) was missing the
lfx package build, causing all cross-platform tests to fail with:

  'No solution found: lfx>=0.4.0 required but only <=0.3.4 available'

Changes:
- Build lfx wheel in build-if-needed job
- Upload lfx artifact (adhoc-dist-lfx)
- Add lfx-artifact-name to job outputs
- Update all test jobs to fallback to build-if-needed outputs
  for lfx artifact (matching existing base/main pattern)
@vjgit96
vjgit96 force-pushed the fix/cross-platform-lfx-build branch from 6374ed5 to 11f6889 Compare April 6, 2026 18:51
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Apr 6, 2026
@codecov

codecov Bot commented Apr 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.11%. Comparing base (2f6400d) to head (11f6889).
⚠️ Report is 2 commits behind head on release-1.9.0.

❌ Your project status has failed because the head coverage (49.06%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-1.9.0   #12524      +/-   ##
=================================================
+ Coverage          49.89%   50.11%   +0.22%     
=================================================
  Files               1930     1932       +2     
  Lines             171894   172029     +135     
  Branches           25319    24163    -1156     
=================================================
+ Hits               85762    86219     +457     
+ Misses             85086    84764     -322     
  Partials            1046     1046              
Flag Coverage Δ
backend 55.90% <ø> (-0.04%) ⬇️
frontend 49.02% <ø> (+0.34%) ⬆️
lfx 49.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 191 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 29%
29.69% (31319/105481) 63.69% (3976/6242) 31.04% (731/2355)

Unit Test Results

Tests Skipped Failures Errors Time
3104 0 💤 0 ❌ 0 🔥 4m 59s ⏱️

@vjgit96
vjgit96 added this pull request to the merge queue Apr 6, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 6, 2026
@vjgit96
vjgit96 added this pull request to the merge queue Apr 6, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 6, 2026
@vjgit96
vjgit96 merged commit 4ee94e6 into release-1.9.0 Apr 6, 2026
93 of 94 checks passed
@vjgit96
vjgit96 deleted the fix/cross-platform-lfx-build branch April 6, 2026 19:58
Adam-Aghili pushed a commit that referenced this pull request Apr 15, 2026
…ch (#12524)

The build-if-needed job (used by workflow_dispatch) was missing the
lfx package build, causing all cross-platform tests to fail with:

  'No solution found: lfx>=0.4.0 required but only <=0.3.4 available'

Changes:
- Build lfx wheel in build-if-needed job
- Upload lfx artifact (adhoc-dist-lfx)
- Add lfx-artifact-name to job outputs
- Update all test jobs to fallback to build-if-needed outputs
  for lfx artifact (matching existing base/main pattern)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants