Skip to content

Fix CHANGELOG duplicates introduced by #3136 - #3162

Merged
adenzler-nvidia merged 1 commit into
newton-physics:mainfrom
adenzler-nvidia:adenzler/fix-changelog-3136-dupes
Jun 12, 2026
Merged

Fix CHANGELOG duplicates introduced by #3136#3162
adenzler-nvidia merged 1 commit into
newton-physics:mainfrom
adenzler-nvidia:adenzler/fix-changelog-3136-dupes

Conversation

@adenzler-nvidia

@adenzler-nvidia adenzler-nvidia commented Jun 12, 2026

Copy link
Copy Markdown
Member

Description

PR #3136 was merged from a branch cut before the 1.3.0 release. The merge re-inserted that branch's stale [Unreleased] entries as an 18-line duplicate block in the now-released [1.3.0] ### Fixed section, where each fix already appears with its canonical PR reference.

This removes the duplicated block so [1.3.0] matches its released state, and adds the missing (#3136) reference to the genuine new entry in [Unreleased]. The result is byte-identical to main immediately before the #3136 merge, plus only that one legitimate entry.

Checklist

  • New or existing tests cover these changes
  • The documentation is up to date with these changes
  • CHANGELOG.md has been updated (if user-facing change)

Test plan

Docs-only change. Verified the diff against pre-merge main contains only the single (#3136) line addition, and that no [1.3.0] entry bodies remain duplicated.

Summary by CodeRabbit

  • Documentation
    • Corrected changelog documentation with missing issue references.

PR newton-physics#3136 was merged from a branch cut before the 1.3.0 release. The
merge re-inserted that branch's stale [Unreleased] entries as an
18-line duplicate block in the now-released [1.3.0] Fixed section,
where each fix already appears with its canonical PR reference.

Remove the duplicated block so [1.3.0] matches its released state, and
add the missing (newton-physics#3136) reference to the genuine new entry in the
[Unreleased] section.
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates CHANGELOG.md to add missing issue references to two existing bug fix entries. Line 16 appends (#3136) to the mesh inertia determinism fix, and line 120 appends (#3088) to the SensorTiledCamera heightfield rendering fix. No code is modified; only changelog text is updated.

Changes

Changelog Updates

Layer / File(s) Summary
Add missing issue references
CHANGELOG.md
Two existing changelog entries under "Unreleased → Fixed" and "Fixed" sections are updated to include their corresponding issue numbers: mesh inertia determinism (#3136) and SensorTiledCamera HFIELD rendering (#3088).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • newton-physics/newton#2913: Also modifies CHANGELOG.md to add missing issue references to existing entries with no code changes.
  • newton-physics/newton#2983: Documentation-only changelog update that relocates and adds multiple entries, including SensorTiledCamera-related items.

Suggested reviewers

  • jcarius-nv
  • eric-heiden
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: fixing duplicate CHANGELOG entries introduced by a specific PR (#3136).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.md`:
- Line 16: Changelog entry wording is incomplete because de-duplication retained
the SensorTiledCamera Unreleased [Fixed] entry with reference (`#3088`) while the
objective only mentions (`#3136`); update the CHANGELOG.md Unreleased section to
mention both fixes by adjusting the objective text to include SensorTiledCamera
and (`#3088`) alongside the mesh inertia fix (`#3136`), and ensure the note about
removing the 18-line duplicate from [1.3.0] remains intact so entries for
SensorTiledCamera, [Fixed], (`#3088`), (`#3136`), and [1.3.0] are all correctly
represented.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: a645537a-0a6e-4ff5-9d15-8362c1fb15b1

📥 Commits

Reviewing files that changed from the base of the PR and between 811968b and fdf6a7d.

📒 Files selected for processing (1)
  • CHANGELOG.md

Comment thread CHANGELOG.md
@adenzler-nvidia
adenzler-nvidia requested review from camevor and nvtw June 12, 2026 12:24
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@camevor camevor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, lgtm!

@adenzler-nvidia
adenzler-nvidia added this pull request to the merge queue Jun 12, 2026
Merged via the queue into newton-physics:main with commit dab4e16 Jun 12, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants