Use newton-usd-schemas 0.4.1 - #3733
Conversation
0.4.1 corrects the base type of NewtonActuator, which was a partially implemented UsdGeomImageable and is now UsdTyped. Actuators are not renderable, so nothing should have been treating them as imageable. It also clarifies in NewtonMimicAPI that the leader and follower must share a joint type, matching what the importer already assumes. Newton identifies actuator prims by type name, so parsing is unchanged either way, but pinning the corrected schema keeps authored stages and the importer describing actuators the same way. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesImporter dependency
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jcarius-nv this isn't really necessary, as the schema patch has no runtime impact on Newton itself. Just keeping things up-to-date really, so it appears that Newton 1.5 "recommends" schemas 0.4.1 There may yet be a 0.5.0 schema release before code freeze, happy to wait for that if you'd prefer |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Description
Bump
newton-usd-schemasto 0.4.1, released to PyPI today.The 0.4.1 patch contains two changes:
NewtonActuatorbase type corrected from a partially implementedUsdGeomImageabletoUsdTyped. Actuators are not renderable, so nothing should have been treating them as imageable. A consequence worth knowing: actuators can no longer be rendered in Hydra-compatible viewers, so a viewer wanting actuator manipulators has to special-case them, or the content author has to parent aUsdGeomImageablebeneath them.NewtonMimicAPIdocumentation clarified to state that the leader and follower must share a joint type; multi-DOF behaviour remains undefined and unsupported. This matches what the importer already assumes — see Read newton:mimicCoef0 as degrees for angular mimic followers #3728, which readsnewton:mimicCoef0as degrees based on the follower's joint type.Newton identifies actuator prims by type name (
prim.GetTypeName() != "NewtonActuator"innewton/_src/actuators/usd_parser.py), so parsing behaves identically against either version. The floor is raised anyway so that authored stages and the importer describe actuators the same way.No
CHANGELOG.mdentry: no Newton-side behaviour changes, matching the precedent for standalone schema bumps (#2012). Happy to add one if you'd rather record it.Checklist
CHANGELOG.mdhas been updated (if user-facing change)Test plan
Confirmed the installed schema actually changed, rather than trusting the version string:
Summary by CodeRabbit