Improve Newton 1.5 changelog - #3786
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthrough
ChangesChangelog updates
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Around line 61-62: Update the Changed entries in CHANGELOG.md for the
per-particle array, ShapeConfig SDF/density, and pre-touch contact-force changes
to include concrete migration guidance: require equal array lengths before
construction or finalization, state or reference the valid SDF and density
validation rules, and identify the supported scene or collision-setting change
for pre-touch contact forces, or explicitly state that no compatibility option
exists.
- Line 133: Update the changelog entry for SolverKamino to use the corrected
wording: state that SolverKamino preserves resets for bodies whose center of
mass is offset from the body frame, including “to” after SolverKamino.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2fe6a9c7-82ab-432b-9914-95b4b082557a
📒 Files selected for processing (1)
CHANGELOG.md
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
a9420ce to
a3bf9c5
Compare
|
Thanks for tightening up the 1.5 changelog, the deprecation and fix entries are much easier to scan now! One thing to double check before merging: one of the moved entries appears to have landed under the wrong release heading. |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CHANGELOG.md (1)
86-106: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winRestore the release and category boundary for these entries.
Lines 86-106 appear directly under the
### Removedheading from Line 79. They are therefore classified as removals. Line 108 then starts a second### Removedsection, and Lines 110-115 repeat the entries from Lines 81-85.Place the unique deprecations under the intended
### Deprecatedheading and remove duplicate entries. If this block belongs to a historical release, restore its missing## [version]heading instead.As per path instructions, keep deprecation and removal entries under their correct release and category headings.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CHANGELOG.md` around lines 86 - 106, Reorganize the changelog entries so the unique deprecations currently between the `### Removed` sections appear under the intended `### Deprecated` heading, and remove the repeated entries in the later `### Removed` block. If this content belongs to a historical release, restore its missing `## [version]` heading while preserving the correct release/category placement.Sources: Path instructions, Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@CHANGELOG.md`:
- Around line 86-106: Reorganize the changelog entries so the unique
deprecations currently between the `### Removed` sections appear under the
intended `### Deprecated` heading, and remove the repeated entries in the later
`### Removed` block. If this content belongs to a historical release, restore
its missing `## [version]` heading while preserving the correct release/category
placement.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro Plus
Run ID: 1ac43230-6020-4a11-9dee-f1d948147cee
📒 Files selected for processing (1)
CHANGELOG.md
|
I think my agent might have screwed up here a bit -- let me double check, do not merge yet. Edit: seems ok now |
2 participants
Description
Audit and improve the Newton 1.5 changelog across the complete
v1.4.0..598c413e9cf6c697233ec922658f6c812c18e6ecrange (194 commits).This change:
v1.4.0by moving ten late 1.4 entriesfor post-release code into
[Unreleased], removing three true duplicates,and preserving Fix misplaced MeshAdjacency changelog entries #3618's corrective relocation of the
MeshAdjacency.edgesdeprecation from 1.2 to 1.4;
evidence-backed PR and issue references;
removing internal-only or overstated entries.
Pre-release audit report:
Newton 1.5.0.dev0 Pre-Release Report.
Checklist
CHANGELOG.mdhas been updated (if user-facing change)Tests are not applicable because this PR changes only release documentation.
Test plan
Also verified that every released-history difference is accounted for, every
moved entry's implementation is absent from
v1.4.0and present in the auditedrange, all added references resolve to their intended changes, and the branch
diff contains only
CHANGELOG.md.Summary by CodeRabbit