Fix broken interpolation placeholders + ui.disabled in Danish localiz… - #56
Fix broken interpolation placeholders + ui.disabled in Danish localiz…#56tocDK wants to merge 1 commit into
Conversation
…ation I was inattentive during the original native review of r11a#45 and let twenty Danish placeholder bugs and one wrong word slip through. The original DeepL pass translated several token placeholder names themselves into Danish words. The runtime interpolation matches by exact token name, so users saw the bare placeholder text at runtime instead of the actual value being substituted. One key (ui.player_count_many) was outright broken — missing closing brace and missing its token entirely. This patch restores all 20 token names to their English originals; the surrounding Danish text is preserved unchanged. Separately: ui.disabled was "Handicappet" (the Danish word for physically handicapped) — replaced with "Inaktiv", the standard Danish word for a UI off-state. This bug predates r11a#45 visibility- wise but became more noticeable after r11a#54 added another "Enabled / Disabled" pill to the Settings panel. Validation: full vitest suite (134/134) passes. Build clean. Localization parity test confirms all keys still aligned across the 8 locales. No other locale needed changes — only Danish had the placeholder regression. This is not the full Danish polish sweep; a follow-up PR is queued with style and naming improvements. This patch keeps the scope to functional bugs + one obvious mistranslation.
|
Thank you for catching and fixing these Danish localization placeholders. This is a clean localization data fix, and I want it included in 5.9.0 before the release. I’ll apply/include this fix in the final 5.9.0 build and credit you for the Danish localization work. Once that is included in the release branch, I’ll close this PR without merging it directly if the final release build already contains the corrected strings. |
|
Thank you again for the Danish language fix and for all the work you put into improving HOMEii Music Flow. I incorporated the Danish localization fixes into the 5.9.0 release, together with the related placeholder/translation cleanup. I also added credit for your contribution in the 5.9.0 release notes. Since the changes are already included in the released version, I’m going to close this PR without merging it directly to avoid duplicating the same changes in the history. Released here: Really appreciate your help and the care you put into this. |
2 participants
Refs #45 (the original Danish locale PR — this is a follow-up fix)
Summary
Fixes 20 broken interpolation placeholders in
src/localization/da.jsplus one obvious mistranslation. All bugs originate from the original Danish PR (#45) where I was inattentive during the native-reviewpass and let DeepL's placeholder translations slip through. Pure data fix — no code, no logic, no test changes.
What was broken
The runtime interpolates
{token}placeholders by exact match against the token name. The original DeepL pass translated several token names themselves into Danish words across 20 keys (sleep-timermessages, voice replies, announcements, queue transfer, player count, etc.). Danish users saw the literal
{titel}/{minutter}/ etc. in the rendered string instead of the actual title or number beingsubstituted in. One key (
ui.player_count_many) was outright broken — missing closing brace and missing its token entirely.Plus one wrong word
ui.disabledwas"Handicappet"— that's the Danish word for physically handicapped, the wrong sense for a UI off-state. Replaced with"Inaktiv". This bug existed in the original Danish PR; it becamemore visible after #54 (disable-confirmation-toasts) added a new pill labelled "Enabled / Disabled" right under "Show Up Next" in the Display settings.
What this PR does NOT do
that — kept out of this one to keep the scope to "bugs only".
Validation
npm run check— 134/134 tests pass (localization parity test confirms all keys still aligned across the 8 locales).npm run build— clean.src/localization/en.jsfor matching token names.Out of scope