Support RISC-V p-ext-proposal v0.9.12 for RV32#2210
Open
jason01180118 wants to merge 33 commits intoriscv-software-src:masterfrom
Open
Support RISC-V p-ext-proposal v0.9.12 for RV32#2210jason01180118 wants to merge 33 commits intoriscv-software-src:masterfrom
jason01180118 wants to merge 33 commits intoriscv-software-src:masterfrom
Conversation
chihminchao
reviewed
Feb 5, 2026
riscv/p_ext_macros.h
Outdated
| #define P_REDUCTION_ULOOP_END(BIT, IS_SAT) \ | ||
| } \ | ||
| if (IS_SAT) { \ | ||
| P_USAT(BIT, p_res); \ |
Contributor
There was a problem hiding this comment.
Should it be
p_res = P_USAT(BIT, p_res);
?
Author
There was a problem hiding this comment.
These instructions no longer have a saturation function in the new P extension spec, so I will remove the if (IS_SAT) condition and clear other build warnings. Thank you for the helpful feedback.
Contributor
|
Just a reminding, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the previous PR #637
Hello, we’re the team from Programming Langauge Lab, NTHU (National Tsing-Hua University), Taiwan.
This PR implements all instructions in the latest P-Extension specification (link)
Branches are split for RV32 and RV64, since some instructions may conflict between architectures.