API Remove code which is being migrated to a new TinyMCE module#11617
API Remove code which is being migrated to a new TinyMCE module#11617emteknetnz merged 1 commit intosilverstripe:6.0from
Conversation
GuySartorelli
force-pushed
the
pulls/6.0/tinymce
branch
4 times, most recently
from
d3eb6c1 to
58567b9
Compare
GuySartorelli
force-pushed
the
pulls/6.0/tinymce
branch
10 times, most recently
from
27e8dfa to
b94410c
Compare
GuySartorelli
force-pushed
the
pulls/6.0/tinymce
branch
6 times, most recently
from
8036736 to
19ec36b
Compare
GuySartorelli
force-pushed
the
pulls/6.0/tinymce
branch
2 times, most recently
from
5db8ee1 to
f8f976e
Compare
| @@ -3,20 +3,276 @@ Name: corehtml | |||
| --- | |||
There was a problem hiding this comment.
Give this a name like framework-html so that it's easier for people to After: in their own yml
I had to After: '*' in my project to get my config to override values here
There was a problem hiding this comment.
It already has a name on Line 2:
Name: corehtml
There was a problem hiding this comment.
I'll add After: 'corehtml' in the docs though, it's good you called this out I didn't consider that might be necessary.
| $this->validValues = (array) $value; | ||
| break; | ||
| default: | ||
| throw new InvalidArgumentException('$valueType must be one of the VALUE_* consts.'); |
There was a problem hiding this comment.
| throw new InvalidArgumentException('$valueType must be one of the VALUE_* consts.'); | |
| throw new InvalidArgumentException('$valueType must be one of the HTMLEditorAttributeRule::VALUE_* consts.'); |
| } | ||
|
|
||
| /** | ||
| * Undocumented function |
There was a problem hiding this comment.
Done but please include the method name when suggesting changes like these - all I have to go off is the line number to know what specific method this is for, and line numbers can change as I apply other recommended changes.
| * Undocumented function | ||
| * | ||
| * @param string $regex | ||
| * @return string |
There was a problem hiding this comment.
Probably delete the docblock param / return type
There was a problem hiding this comment.
Not sure what method this was but I've documented all methods with "Undocumented function"
| } | ||
|
|
||
| /** | ||
| * Undocumented function |
GuySartorelli
force-pushed
the
pulls/6.0/tinymce
branch
from
f8f976e to
5292f58
Compare
GuySartorelli
force-pushed
the
pulls/6.0/tinymce
branch
from
5292f58 to
00da541
Compare
GuySartorelli
force-pushed
the
pulls/6.0/tinymce
branch
from
00da541 to
be6b051
Compare
2 participants
Important
Make sure you test this without the new tinymce module installed as well to ensure the textarea HTML editor field works, and that on save any disallowed elements/attributes are removed.
All other PRs will still need to be included because otherwise PHP will fail to run because there are references to missing classes lol
Issue