Skip to content

[MPQEditor] Create or edit mixed precision quantization json file.#1505

Draft
stamalakhov wants to merge 1 commit intoSamsung:mainfrom
stamalakhov:manual_MPQ_BR
Draft

[MPQEditor] Create or edit mixed precision quantization json file.#1505
stamalakhov wants to merge 1 commit intoSamsung:mainfrom
stamalakhov:manual_MPQ_BR

Conversation

@stamalakhov
Copy link
Copy Markdown
Contributor

@stamalakhov stamalakhov commented Feb 16, 2023 •
edited
Loading

This commit allows to create or edit mixed precision quantization json file.
To use the tool the following actions are suggested:

  1. right-click in explorer any circle model
  2. context menu should contain "Create MPQ json" - click it
  3. provide name for new .json
  4. after creation of new json we may edit it

Related: #1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov s.malakhov@partner.samsung.com

@stamalakhov stamalakhov self-assigned this Feb 16, 2023
@stamalakhov stamalakhov force-pushed the manual_MPQ_BR branch 2 times, most recently from 3702a75 to ea65d9e Compare February 16, 2023 08:02
@stamalakhov
Copy link
Copy Markdown
Contributor Author

stamalakhov commented Feb 16, 2023

More info:
1_2
gen_info
select_layers
show_model_graph
VISQ_INFO

seanshpark
seanshpark reviewed Feb 16, 2023
View reviewed changes
Comment thread media/CircleGraph/index.js Outdated
seanshpark
seanshpark reviewed Feb 16, 2023
View reviewed changes
Comment thread media/CircleGraph/index.js Outdated
seanshpark
seanshpark reviewed Feb 16, 2023
View reviewed changes
Comment thread media/CircleGraph/index.js Outdated
Copy link
Copy Markdown
Contributor

@seanshpark seanshpark Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo whicj

Copy link
Copy Markdown
Contributor

@seanshpark seanshpark Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this mode added?
what is visqselr? this word is hard to read.

Copy link
Copy Markdown
Contributor Author

@stamalakhov stamalakhov Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this mode added?

new mode is intended to provide .visq colormap, as well as selector capabilities to provide a user handy selection of nodes.

what is visqselr? this word is hard to read.

Yes. The name is hard to read, i'll gladly change it with any other more fortunate name.

seanshpark
seanshpark reviewed Feb 16, 2023
View reviewed changes
Comment thread media/CircleGraph/index.js Outdated
Copy link
Copy Markdown
Contributor

@seanshpark seanshpark Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only put this line as there is no other change

Copy link
Copy Markdown
Contributor Author

@stamalakhov stamalakhov Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only put this line as there is no other change

Sorry. I don't quite get it. Current implementation assumes that we can change html _mode to another mode, so these lines are intended to provide full enumeration of viewMode, but for now only visqselr is enough.

Copy link
Copy Markdown
Contributor

@seanshpark seanshpark Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but for now only visqselr is enough.

this is the point. check only for visqselr. setting to other modes are never called.

Copy link
Copy Markdown
Contributor Author

@stamalakhov stamalakhov Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh. Thank you. Ok.

seanshpark
seanshpark reviewed Feb 16, 2023
View reviewed changes
Comment thread src/MPQEditor/MPQCircleSelector.ts Outdated
@jinevening
Copy link
Copy Markdown

jinevening commented Feb 17, 2023

Q) How visq info is created? Is it assumed to be generated before? If so, it would be better to give instruction on how to make visq info (e.g., making a small question mark icon near the "Load visq info" button). BTW, is it possible to create visq info in ONE-vscode?

(optional) I think it is better to show the model graph by default when the tab is first created. I guess most users will want to select layers in the graph with visq info.

@stamalakhov stamalakhov marked this pull request as draft February 17, 2023 05:19
@stamalakhov
Copy link
Copy Markdown
Contributor Author

stamalakhov commented Feb 17, 2023

Q) How visq info is created? Is it assumed to be generated before?

Yes, for this draft it was generated before.

If so, it would be better to give instruction on how to make visq info (e.g., making a small question mark icon near the "Load visq info" button)

ok.

BTW, is it possible to create visq info in ONE-vscode?

I'll investigate it.

(optional) I think it is better to show the model graph by default when the tab is first created. I guess most users will want to select layers in the graph with visq info.

Ok.

I'll be back with reworked draft.

@stamalakhov
Copy link
Copy Markdown
Contributor Author

stamalakhov commented Feb 17, 2023 •
edited
Loading

Currently the workflow looks like this:

last_screen_cast

@stamalakhov stamalakhov force-pushed the manual_MPQ_BR branch 2 times, most recently from b87a618 to a9ebb2d Compare February 20, 2023 09:56
@stamalakhov
Copy link
Copy Markdown
Contributor Author

stamalakhov commented Feb 20, 2023

BTW, is it possible to create visq info in ONE-vscode?

I've tried to introduce visq data computation into MPQEditor and it occured to be heavy:
input for float model
input for quantized model
input for h5 data
ouput for MPEIR mode
ouput for MSE mode
...
to be continued

IMHO for visq component we may try to create additional command in ONE-vscode.
@jinevening
May be we could do another item in context menu for circle file like "Create VISQ data" ?

@stamalakhov
Copy link
Copy Markdown
Contributor Author

stamalakhov commented Feb 20, 2023

@jinevening @seanshpark
Please see docs/MPQEditor.md for readme.
For now model-graph-view is opened by default.
And help btn is also introduced into visq_path input.
image

@seanshpark
Copy link
Copy Markdown
Contributor

seanshpark commented Feb 20, 2023 •
edited
Loading

Thanks for video attach at #1505 (comment) :)

Q1) what happens if wrong json (not visq info content) is selected in visq info ?
Q2) what happens if wrong json (visq info content but for different model) is selected in visq info ?
Q3) there seems to be no way to clear loaded visq info. is there any particular reason for this?

model.json filename doesn't seem to be appropriate. we can't distinguish by just .json. how about use model.blabla.json ? @jinevening , do you have any good word for blabla ?

dayo09
dayo09 reviewed Feb 20, 2023
View reviewed changes
Comment thread package.json Outdated
dayo09
dayo09 reviewed Feb 20, 2023
View reviewed changes
Comment thread src/MPQEditor/MPQCircleSelector.ts Outdated
dayo09
dayo09 reviewed Feb 20, 2023
View reviewed changes
Comment thread src/MPQEditor/MPQCircleSelector.ts Outdated
Copy link
Copy Markdown
Contributor

@dayo09 dayo09 Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, it's rather safer to use vscode.workspace.fs.readFile instead of fs.readFileSync. Related issue: #746

Copy link
Copy Markdown
Contributor Author

@stamalakhov stamalakhov Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thank you. I didn't know that.

dayo09
dayo09 reviewed Feb 20, 2023
View reviewed changes
Comment thread src/MPQEditor/MPQCircleSelector.ts Outdated
Copy link
Copy Markdown
Contributor

@dayo09 dayo09 Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q. Is it fine with this.update() being commented out?

Copy link
Copy Markdown
Contributor Author

@stamalakhov stamalakhov Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... Sorry. I'll remove that.

dayo09
dayo09 reviewed Feb 20, 2023
View reviewed changes
Comment thread src/MPQEditor/MPQCircleSelector.ts Outdated
Comment on lines 222 to 223
Copy link
Copy Markdown
Contributor

@dayo09 dayo09 Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be removed, if it's not used?

Copy link
Copy Markdown
Contributor Author

@stamalakhov stamalakhov Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh.. Sorry. These lines will be removed.

dayo09
dayo09 reviewed Feb 20, 2023
View reviewed changes
Comment thread src/MPQEditor/MPQCircleSelector.ts Outdated
seanshpark
seanshpark reviewed Feb 21, 2023
View reviewed changes
Comment thread docs/MPQEditor.md Outdated
Copy link
Copy Markdown
Contributor

@seanshpark seanshpark Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refine this image. do not use red color for text. use smaller size for explanation.

Copy link
Copy Markdown
Contributor

@seanshpark seanshpark Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "Default Parameters" in GUI not in this image.

Copy link
Copy Markdown
Contributor Author

@stamalakhov stamalakhov Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh... Sorry. I'll fix it.

This was referenced Apr 3, 2023
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 11, 2023
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 18, 2023
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 25, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dayo09 dayo09 mentioned this pull request May 2, 2023
Open
This was referenced May 2, 2023
Merged
Merged
This was referenced May 11, 2023
Merged
Merged
@stamalakhov stamalakhov mentioned this pull request May 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dayo09 dayo09 dayo09 left review comments

@jinevening jinevening Awaiting requested review from jinevening

@seanshpark seanshpark Awaiting requested review from seanshpark

At least 1 approving review is required to merge this pull request.

Assignees

@stamalakhov stamalakhov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stamalakhov @jinevening @seanshpark @dayo09