[COLLAB-CON-1]: getFlowConnections query

[kevinkim-ogp]

TL;DR

Added a new getFlowConnections query to fetch shared connection.

What changed?

• Created a new GraphQL query resolver getFlowConnections that returns connections associated with a specific flow
• Added a new GraphQL type SharedFlowConnection to represent flow connections in the schema
• Implemented handling for both regular connections and table connections
• Added comprehensive tests to verify the functionality works correctly for different connection types
• Updated the query resolvers to include the new resolver

How to test?

1. Query the GraphQL endpoint with:

   query {
     getFlowConnections(flowId: "your-flow-id") {
       flowId
       connectionId
       connectionType
       appName
       appIconUrl
       addedBy
       connectionName
     }
   }

2. Verify that regular connections (like Slack, Telegram) returned with the correct information
3. Verify that Tile connections are returned with the correct Tile name

---

Note

Introduces getFlowConnections to return a flow’s shared connections (apps and tables) with app metadata and contributor info, updating schema/resolvers and adding tests.

• GraphQL:
  • New Query: getFlowConnections(flowId: String!) returning [SharedFlowConnection!]!.
  • New Type: SharedFlowConnection with flowId, connectionId, connectionType, appName, appIconUrl, addedBy, connectionName.
  • Resolver: Implements queries/get-flow-connections.ts:
    • Authorizes via currentUser.withAccessibleFlows(requiredRole: 'editor').
    • Fetches from FlowConnections with connection, table, and user relations.
    • Maps app metadata from App.findAll(); uses tiles for table connections.
    • Filters out entries without a loaded connection or table.
  • Wiring: Adds resolver to query-resolvers.ts and schema.
• Model:
  • Adds optional user?: User property to FlowConnections.
• Tests:
  • Adds unit tests for regular connections, table connections, and mixed results in __tests__/queries/get-flow-connections.test.ts.

^{Written by Cursor Bugbot for commit fc3338d. This will update automatically on new commits. Configure here.}

[kevinkim-ogp]

• refactor: connections display #1552
• [COLLAB-CON-6] (feat): editor can add their tiles #1551
• [COLLAB-CON-5] PLU-661 (feat): editor can add, delete connections #1492
• [COLLAB-CON-4]: (frontend) delete flow connection #1340
• [COLLAB-CON-3]: deleteFlowConnection mutation #1339
• [COLLAB-CON-2]: (frontend) view shared connections #1338
• [COLLAB-CON-1]: getFlowConnections query #1337 👈 (View in Graphite)
• develop-v2

---

How to use the Graphite Merge Queue

Add the label lfg to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[kevinkim-ogp]

bugbot run

[cursor]

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[cursor]

Bug: Filter doesn't match connectionType, causing undefined connectionName

The filter keeps records where connection OR table exists, but the subsequent logic uses connectionType to determine which relation to read from. If connectionType is 'table' but only connection exists (or vice versa), the record passes the filter but connectionName becomes undefined. The GraphQL schema declares connectionName: String! as non-nullable, so returning undefined will cause a runtime error. The filter needs to verify the correct relation exists based on connectionType.

Additional Locations (1)

• packages/backend/src/graphql/queries/get-flow-connections.ts#L33-L37

 

[pregnantboy]

Tested and works. Only main thing to change is the permission check for flow not correct. and the later filters for connectionType can be better refactored

[pregnantboy]

Suggested change

	if (flowConnection.connectionType === 'table') {
	if (flowConnection.connectionType === 'table' && flowConnection.table) {

[pregnantboy]

Suggested change

	const app = apps.find((app: IApp) => app.key === appKey)
	const app = apps.find((app: IApp) => app.key === (flowConnection.connectionType === 'table' ?
	'tiles' : appKey))

[pregnantboy]

lgtm

[graphite-app]

The error message will be misleading for table connections. When connectionType === 'table', appKey is undefined (since flowConnection.connection doesn't exist), but the actual key being searched for is 'tiles'. The error will say "App not found for key: undefined" instead of "App not found for key: tiles".

Fix:

const appKey = flowConnection.connectionType === 'table' 
  ? 'tiles' 
  : flowConnection.connection?.key

const app = apps.find((app: IApp) => app.key === appKey)

if (!app) {
  throw new Error(`App not found for key: ${appKey}`)
}

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.