Skip to content

refactor: connections display#1552

Open
kevinkim-ogp wants to merge 4 commits intocollab-conn/editor-tilesfrom
collab-conn/refactor-connections-display
Open

refactor: connections display#1552
kevinkim-ogp wants to merge 4 commits intocollab-conn/editor-tilesfrom
collab-conn/refactor-connections-display

Conversation

@kevinkim-ogp
Copy link
Copy Markdown
Contributor

@kevinkim-ogp kevinkim-ogp commented Apr 17, 2026

TL;DR

  • Refactor Editor settings page
  • Refactor the Flow Connections table
  • Improved Pipe Transfer warning message
  • Improved Add collaborators warning message

What changed?

  • Modified getFlowConnections to check for flow collaborators and fetch connections from different sources:
    • Flows without collaborators: fetch connections directly from steps (with isDeletable: false)
    • Flows with collaborators: fetch from the flow_connections table (with isDeletable: true)
  • UI Improvements:
    • Added isDeletable field to the GraphQL schema and connection objects
    • Updated the connections table to only show delete buttons for deletable, unused connections
    • Redesigned the collaborators and transfer sections with better layout and information boxes
    • Added connection review links and warnings for pipe transfers
    • Improved mobile/desktop responsive layout with sticky navigation

Reference

https://www.figma.com/design/ccKWZUBzIit4brUenBjE9d/Pipe-Settings?node-id=0-1&p=f&t=eoTQDAkjetYC90es-0

How to test?

Connections page

  • Lists all connections in the Pipe regardless of whether Pipe is shared or not
  • For shared Pipes with Editor-added connections, should reflect the correct 'Added by'
  • Verify NO delete button for Pipes that do not have collaborators
  • Verify NO delete button for Connections that are in use
  • Verify delete button shown for shared Connection but no longer in use

Collaborators (sanity _check)
_Collaborators are now displayed in a table for clarity. Do a sanity check to ensure no regression

  • Verify that 'Review connections' opens to Connections page
  • Verify can add Editor
  • Verify can add Viewer
  • Verify can remove Editor
  • Verify can remove Viewer
  • Verify can change role

Transfer Pipe (sanity check)

  • Verify warning message with M365 warning is shown ONLY for Pipes with M365 actions
  • Verify that 'Review connections' opens to Connections page
  • Verify that only Owner can initiate Pipe Transfer (regardless of deleted Tile or Connection)

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label lfg to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kevinkim-ogp kevinkim-ogp changed the base branch from collab-conn/editor-tiles to graphite-base/1552 April 17, 2026 08:35
@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/refactor-connections-display branch from dc0d624 to 5c27ca0 Compare April 17, 2026 09:09
@kevinkim-ogp kevinkim-ogp changed the base branch from graphite-base/1552 to collab-conn/editor-tiles April 17, 2026 09:09
@kevinkim-ogp kevinkim-ogp marked this pull request as ready for review April 19, 2026 04:38
@kevinkim-ogp kevinkim-ogp requested a review from a team as a code owner April 19, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant