Skip to content

[COLLAB-CON-4]: (frontend) delete flow connection#1340

Open
kevinkim-ogp wants to merge 3 commits intocollab-conn/delete-flow-connection-mutationfrom
collab-conn/delete-flow-connection-frontend
Open

[COLLAB-CON-4]: (frontend) delete flow connection#1340
kevinkim-ogp wants to merge 3 commits intocollab-conn/delete-flow-connection-mutationfrom
collab-conn/delete-flow-connection-frontend

Conversation

@kevinkim-ogp
Copy link
Copy Markdown
Contributor

@kevinkim-ogp kevinkim-ogp commented Nov 25, 2025

TL;DR

  • Adds the ability to delete shared connections from a flow in the UI.
  • Checks if the shared connection existed in flow_connections and was deleted, and restores it rather than attempt to create a new entry

How to test?

  • Cannot delete flow connection when Pipe is published

Delete a flow connection

  • Removed from UI
  • Removed from Step(s) that use the flow connection

Screenshots

Screenshot 2025-11-26 at 11.50.09 AM.png

Screenshot 2025-11-26 at 11.56.27 AM.png

Copy link
Copy Markdown
Contributor Author

kevinkim-ogp commented Nov 25, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label lfg to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kevinkim-ogp kevinkim-ogp changed the title feat: delete flow connections frontend [COLLAB-CON-4]: delete flow connection frontend Nov 26, 2025
@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-frontend branch from 743af41 to 6c5e1ce Compare November 26, 2025 14:07
@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-mutation branch from aa4a8f0 to 7b8e37b Compare November 26, 2025 14:07
@kevinkim-ogp kevinkim-ogp marked this pull request as ready for review November 27, 2025 01:56
@kevinkim-ogp kevinkim-ogp requested a review from a team as a code owner November 27, 2025 01:56
@kevinkim-ogp kevinkim-ogp changed the title [COLLAB-CON-4]: delete flow connection frontend [COLLAB-CON-4]: (frontend) delete flow connection Dec 2, 2025
@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-frontend branch from 6c5e1ce to fcee3b3 Compare March 19, 2026 14:14
@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-mutation branch from 7b8e37b to 1e60433 Compare March 19, 2026 14:14
@kevinkim-ogp kevinkim-ogp changed the base branch from collab-conn/delete-flow-connection-mutation to graphite-base/1340 March 19, 2026 15:34
@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-frontend branch from fcee3b3 to 6df2a47 Compare March 27, 2026 03:11
@kevinkim-ogp kevinkim-ogp changed the base branch from graphite-base/1340 to collab-conn/delete-flow-connection-mutation March 27, 2026 03:11
Copy link
Copy Markdown
Contributor

@pregnantboy pregnantboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works well. following up from previous PR comments, the delete button for connections in use can be greyed out with a tooltip that says that it's still being used in the pipe. I think no need to disable when pipe is published for connections not in use.

@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-frontend branch from 6df2a47 to bc9c25c Compare March 31, 2026 01:23
@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-mutation branch from be8b6d5 to 7e0ba60 Compare March 31, 2026 01:23
Copy link
Copy Markdown
Contributor Author

kevinkim-ogp commented Mar 31, 2026

Refactored

Delete button is disabled when Pipe is active or when Connection is in use.

Tests

  • Delete button is disabled when Pipe is active
  • Delete button is disabled when Connection is in use.

@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-frontend branch from bc9c25c to 3f348d4 Compare March 31, 2026 01:53
Copy link
Copy Markdown
Contributor

@pregnantboy pregnantboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm works well!

@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-mutation branch from eb44857 to c31c15c Compare April 6, 2026 23:37
@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-frontend branch from 3f348d4 to 0033935 Compare April 6, 2026 23:37
@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-frontend branch from 0033935 to fac3f08 Compare April 15, 2026 11:46
@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-mutation branch from c31c15c to 3ca6639 Compare April 15, 2026 11:46
@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-frontend branch from fac3f08 to 91dc57c Compare April 16, 2026 15:14
@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/delete-flow-connection-mutation branch from 3ca6639 to 385cd7f Compare April 16, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants