[COLLAB-CON-4]: (frontend) delete flow connection#1340
[COLLAB-CON-4]: (frontend) delete flow connection#1340kevinkim-ogp wants to merge 3 commits intocollab-conn/delete-flow-connection-mutationfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label lfg to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
743af41 to
6c5e1ce
Compare
aa4a8f0 to
7b8e37b
Compare
6c5e1ce to
fcee3b3
Compare
7b8e37b to
1e60433
Compare
1e60433 to
be8b6d5
Compare
fcee3b3 to
6df2a47
Compare
pregnantboy
left a comment
There was a problem hiding this comment.
tested and works well. following up from previous PR comments, the delete button for connections in use can be greyed out with a tooltip that says that it's still being used in the pipe. I think no need to disable when pipe is published for connections not in use.
6df2a47 to
bc9c25c
Compare
be8b6d5 to
7e0ba60
Compare
RefactoredDelete button is disabled when Pipe is active or when Connection is in use. Tests
|
bc9c25c to
3f348d4
Compare
eb44857 to
c31c15c
Compare
3f348d4 to
0033935
Compare
0033935 to
fac3f08
Compare
c31c15c to
3ca6639
Compare
fac3f08 to
91dc57c
Compare
3ca6639 to
385cd7f
Compare

TL;DR
flow_connectionsand was deleted, and restores it rather than attempt to create a new entryHow to test?
Delete a flow connection
Screenshots