[COLLAB-CON-3]: deleteFlowConnection mutation

[kevinkim-ogp]

No description provided.

[kevinkim-ogp]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• refactor: connections display #1552
• [COLLAB-CON-6] (feat): editor can add their tiles #1551
• [COLLAB-CON-5] PLU-661 (feat): editor can add, delete connections #1492
• [COLLAB-CON-4]: (frontend) delete flow connection #1340
• [COLLAB-CON-3]: deleteFlowConnection mutation #1339 👈 (View in Graphite)
• [COLLAB-CON-2]: (frontend) view shared connections #1338
• [COLLAB-CON-1]: getFlowConnections query #1337
• develop-v2

---

How to use the Graphite Merge Queue

Add the label lfg to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[pregnantboy]

As discussed, it would be simpler and safer if we only allow deletion of the flow connection iff the connection is not in use. i.e. users need to manually delete the step or re-configure the relying steps if they want to remove it.

[kevinkim-ogp]

Refactored

Blocks deletion if the connection is in-use

Tests

Call the mutation directly via Apollo extension or Postman

• Cannot delete connection if its in-use
• Cannot delete Tile connection if its in-use
• Should throw BadUserInputError if Pipe is published
• Should throw ForbiddenError if you do not have access to the Pipe

[datadog-opengovsg]

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 385cd7f | Docs | Was this helpful? Give us feedback!}

[pregnantboy]

lgtm, works well! One small nit for delete-flow-connection: connectionType doesn't need to be part of the input since it can be retrieved from the DB. Also, consider checking that the FlowConnection exists before performing the other validation checks.