Skip to content

[COLLAB-CON-6] (feat): editor can add their tiles#1551

Open
kevinkim-ogp wants to merge 2 commits intocollab-conn/editor-connectionsfrom
collab-conn/editor-tiles
Open

[COLLAB-CON-6] (feat): editor can add their tiles#1551
kevinkim-ogp wants to merge 2 commits intocollab-conn/editor-connectionsfrom
collab-conn/editor-tiles

Conversation

@kevinkim-ogp
Copy link
Copy Markdown
Contributor

@kevinkim-ogp kevinkim-ogp commented Apr 16, 2026

TL;DR

  • Allow editors to add their own tiles
  • Update cleanup

What changed?

  • Editors can now add their own tiles to flows, with the flow owner automatically granted owner permissions on those tiles
  • Dynamic Data Filtering: Updated getDynamicData to show editors both shared tiles and their own tiles, while viewers only see shared tiles in the current flow
  • Connection Management: Removed owner-only restriction for adding tile connections while maintaining it for other connection types
  • Delete Tile from flow_connections when the Tile is deleted
  • Delete all connections in flow_connections when the Pipe is deleted

How to test?

Adding Tiles as an Editor

  • Verify that Editor can view their own Tiles in the selector
  • Verify that all Pipe collaborators are added to the Tiles with the correct roles
    • Viewers added as viewers
    • Editors added as editors
    • Owner added as editor
  • Verify that Owner can still add their own Tiles and the Pipe collaborators are added correctly
  • Verify that Viewer still cannot add Tile

Deleting Pipe

  • Verify that connections in flow_connections are also deleted

Deleting Tile

  • Verify that Tile connections in flow_connections are also deleted

Copy link
Copy Markdown
Contributor Author

kevinkim-ogp commented Apr 16, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label lfg to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kevinkim-ogp kevinkim-ogp changed the title feat: editor can add their tiles [COLLAB-CON-6] (feat): editor can add their tiles Apr 16, 2026
@datadog-opengovsg

This comment has been minimized.

@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/editor-tiles branch from a22a5c3 to d7d0c76 Compare April 16, 2026 15:22
@kevinkim-ogp kevinkim-ogp marked this pull request as ready for review April 16, 2026 15:47
@kevinkim-ogp kevinkim-ogp requested a review from a team as a code owner April 16, 2026 15:47
@kevinkim-ogp kevinkim-ogp mentioned this pull request Apr 17, 2026
14 tasks
@kevinkim-ogp kevinkim-ogp changed the base branch from collab-conn/editor-connections to graphite-base/1551 April 17, 2026 08:24
@kevinkim-ogp kevinkim-ogp force-pushed the collab-conn/editor-tiles branch from d7d0c76 to e99c6ed Compare April 17, 2026 08:35
@kevinkim-ogp kevinkim-ogp changed the base branch from graphite-base/1551 to collab-conn/editor-connections April 17, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant